Skip to content

🌱 sync: forward-merge v5 (v5.136.x) into v6 β€” #10590 decision C - #10738

Merged
clubanderson merged 194 commits into
v6from
sync/v5-to-v6-10590
Oct 6, 2026
Merged

clubanderson merged 194 commits into
v6from
sync/v5-to-v6-10590

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Closes #10590

Follow-up for option A: #10734

Resolution table

File/area Resolution
src/Dockerfile Union: v5 GOOS/GOARCH on Go builds plus v6 hive-admin-mcp binary.
src/cmd/hive/main.go Kept v6 resolveSpokeDashboardURL; v5 side was equivalent/commentary in the conflict.
src/docs/api-reference.md Kept v6 citation shape and applied v5 prose renames (Projects cards, Throughput). Citation fixer not run locally because AGENTS.md forbids local citation guards unless CI requests it.
src/docs/integration-guide.md, src/docs/integrations/work-source-providers.md, src/docs/labels-and-control-signals.md Kept v6 content and applied v5 wording updates for Throughput and filtered needs-* labels.
src/go.mod Union of v6 oauth2/sync/time/uritemplate deps and v5 go.opentelemetry.io/otel/log.
src/hive.yaml.example / src/pkg/config/runs_config* Union of v6 hub executor/interview/checkpoints and v5 recheck/discovery config keys and defaults.
src/pkg/config/config.go / split config files Kept v6 split config; ported openhands into backends.go; retained v6 hub config comments.
src/pkg/dashboard/api.go Registered both /api/feedback/nps/issue and /api/feedback/status; retained campaign recheck endpoint.
src/pkg/dashboard/api_campaigns.go / src/pkg/knowledge/inception.go Union of v6 run/revision fields/history with v5 recheck/drift types.
src/pkg/dashboard/campaign_recheck.go Decision C: endpoint/config/types stay, triggerCampaignRecheck returns 501 with a clear #10734 message; cadence tick is inert on v6.
src/pkg/dashboard/api_campaigns_test.go, src/pkg/dashboard/recheck_discovery_test.go v5 recheck tests are skipped on v6 with t.Skip citing #10734.
src/pkg/dashboard/stage_leases.go Kept v6 work-item title/URL behavior; recheck spec-title behavior is deferred with #10734.
src/pkg/dashboard/static/index.html, version_provenance_ui_test.go, api_governor_features.go Unioned v6 background activity/checkpoints/extensions/Gitea/GitLab/External UI with v5 KPI/version/wavefront/recheck surfaces.
src/pkg/dashboard/webstatic/style_ratchet_test.go Ratchet baselines retained/updated for the merged tree: operator page 1690/149/693/240/185; hub static pages 964/456/427/167/104.
src/internal/testutil/sleep_ratchet_test.go Union baseline is 201 sleeps.
src/pkg/hub/stable_promotion.go Removed the duplicate mustParseRFC3339; only v6 health_verdict.go copy remains.

Recheck disabled on v6

Per #10590 decision C, the v5 Spek continuous convergence recheck and outward discovery model is not ported in this PR. Config keys, types, UI affordances, and endpoints remain present for compatibility, but manual/cadence recheck execution returns HTTP 501 until #10734 ports the feature onto v6's in-place campaign revision model. v6 must not ship a release until #10734 lands.

Validation

AGENTS.md forbids local go build, go test, go vet, and docs citation guard runs in this repository. Local checks run:

  • gofmt -l on touched Go files: clean
  • node --check bin/contributor-relay.js
  • node --check bin/contributor-relay.test.js
  • extracted inline JS from src/pkg/dashboard/static/index.html and ran node --check: clean
  • confirmed one func mustParseRFC3339 remains under src/pkg/hub
  • git diff --cached --check: clean

Coverage/package ratchets were not re-measured locally because package tests are forbidden for agents here; CI is the source of truth.

scanner and others added 30 commits October 5, 2026 08:53
…kick claims

Signed-off-by: scanner <scanner@hive.kubestellar.io>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
…10042) (#10555)

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.132.9 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* πŸ› release: keep promotion evidence API authenticated

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* changelog: fragment for #10564

Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
…0443) (#10575)

Signed-off-by: scanner <scanner@hive.kubestellar.io>
Co-authored-by: scanner <scanner@hive.kubestellar.io>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
…idebar-10563

πŸ› dashboard: section titles match sidebar labels (Repositories β†’ Projects)
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
…0581)

Signed-off-by: scanner <scanner@hive.kubestellar.io>
Co-authored-by: scanner <scanner@hive.kubestellar.io>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
…alth-10559

πŸ› hub: restore node stats for pull-only clusters via heartbeat health; neutral awaiting-heartbeat state
clubanderson and others added 2 commits October 5, 2026 19:54
* πŸ› fix: do not claim dependency-blocked issues on kick

The kick footer tells the agent 'Blocked by open dependencies β€” do NOT
start these', but KickMessage.IssueRefs still carried those issues, so
recordAgentKickClaims posted a πŸ”’ 'Claimed by agent scanner' comment on
them every kick cycle (seen 4x each on hive#10598/#10599 while blocked
on #10595). Filter blocked issues out of IssueRefs alongside in-flight
ones.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Anderson <andy@clubanderson.com>

* changelog: fragment for #10724

Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>

---------

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…entry (#10728)

The guide was published and reviewed under operator decision on #10515
(hive #10704 removed the in-page notice); documentation-map.md still
carried the old caveat.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 6, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@clubanderson
clubanderson force-pushed the sync/v5-to-v6-10590 branch 4 times, most recently from 7ddd362 to 57e8e2a Compare October 6, 2026 00:57
Apply decision C: keep the Spek recheck config/types/endpoints on v6 but return 501 from triggerCampaignRecheck pending #10734, with recheck tests skipped accordingly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Signed-off-by: Andy Anderson <andy@clubanderson.com>

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
- TestGovWorkSource_WavefrontValidation / TestGovWorkSource_ExternalRejectsLiteralToken: the merge nested the wavefront validation inside the external block and dropped the return after the external validation error; restore the early return and un-nest wavefront validation so rejected PUTs 400 without mutating config.
- TestDashboardSectionTitlesMatchSidebarLabels / TestInceptionSidebarLabelsSpektacular: card title is now 'πŸ’‘ Inception (spektacular)' to match the sidebar label, and the section header is restored to v6's 'Project Inception Β· powered by Spektacular'.
- TestIssueClaimsFeatureTooltip: tooltip says 'hive:claim marker comment' (the real marker in pkg/issueclaim; hive-claim is legacy).
- TestNavbarStickyThreeZoneLayout: restore oc-topbar-center holding fleet-breaker-wrap and agent-navbar-upnext; close the nav-chip-group span the merge left open.
- TestBackendSupportTiersAdvisorEntryCoversEveryBackend: add the openhands row (No) to the advisor lane table.
- TestSleepRatchet: raise sleepBaseline 201β†’203 for sleeps carried in from already-merged v5 tests (merge-only bump).

Signed-off-by: scanner <scanner@hive.kubestellar.io>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive/awaiting-ci: pushed a fixup (8652255) for the 8 union test failures (worksource wavefront/external validation nesting, inception title/header, hive:claim tooltip, topbar three-zone center, openhands advisor doc row, sleep ratchet 201β†’203). CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 865225524

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

The forward-merge kept v6's older renderVersionDetails/renderVersionChip
(typeof-guarded fallbacks, versionTrackingLabel) while carrying v5's
version_provenance_ui_test.go, so TestVersionProvenanceRendering failed
on the "2 behind"/"pinned a1b2c3d" assertions. Adopt v5's renderers and
the v5 test as of the merged v5 commit (43d631f); pkg/dashboard passes
under CI's shuffle seed 1791249651411000803.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two red test shards (dashboard shuffle 1/2, rest 1/5) are one deterministic failure, and it is a merge-resolution regression rather than flake:

version_provenance_ui_test.go:34: version renderer failed: exit status 1
  assert.ok(out.menu.includes('2 behind'))   // actual: false

Mechanism. In fetchGitVersion, v6 computes a local statusText that becomes "2 behind" when commitsBehind is known (src/pkg/dashboard/static/index.html:27582 on this head, same as v6 :26176) and then hands that local to the renderers via window._lastVersionContext = { …, statusText: statusText, … } (v6 :26198). This merge took v5's version of that line instead β€” statusText: versionStatusSummary(v, offeredUpgradeShort) (index.html:27604, from v5 :26669). versionStatusSummary returns 'upgrade available β†’ b2c3d4e' for any behind: true payload and never reaches the N behind text, so the local at :27582 is now computed and discarded, and renderVersionDetails (which only reads ctx.statusText) no longer shows the commit count. The v6 test asserting '2 behind' (version_provenance_ui_test.go:117) was kept, so it fails. v6 tip a909f89 passes this test.

Fix. Either restore v6's resolution at index.html:27604 β€” statusText: statusText β€” which keeps v6's "N behind" menu row (v5's new renderVersionSurfaces/navbar indicator is unaffected by this one field), or, if dropping the count in favour of the v5 summary is intended under decision C, say so and update the assertion at version_provenance_ui_test.go:117. The former preserves v6 behaviour and is the one I'd expect for a forward-merge.

Scope note: I read only this failure and the version-rendering functions it touches, not the other 313 files. The probot DCO failure is the usual forward-merge false positive on others' commits and is unrelated.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@clubanderson
clubanderson merged commit 5978664 into v6 Oct 6, 2026
67 of 69 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the sync/v5-to-v6-10590 branch October 6, 2026 01:40
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

clubanderson added a commit that referenced this pull request Oct 6, 2026
Top up v6 with origin/v5 after #10738. Keep the v6 in-place Spek recheck and proxy-only discovery implementation from #10807/#10809; #10734 is closed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
clubanderson added a commit that referenced this pull request Oct 6, 2026
Top up v6 with origin/v5 after #10738. Keep the v6 in-place Spek recheck and proxy-only discovery implementation from #10807/#10809; #10734 is closed.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants