Repository navigation
π± sync: forward-merge v5 (v5.136.x) into v6 β #10590 decision C - #10738
Conversation
β¦kick claims Signed-off-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Automated release commit. Compiles changelog.d/ fragments and moves the CHANGELOG.md Unreleased section into a dated v5.132.9 entry. See src/docs/releases.md. Signed-off-by: hive-release-bot <actions@github.com>
release: v5.132.9
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
* π release: keep promotion evidence API authenticated Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> * changelog: fragment for #10564 Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
β¦idebar-10563 π dashboard: section titles match sidebar labels (Repositories β Projects)
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Signed-off-by: Andy Anderson <andy@clubanderson.com>
β¦0581) Signed-off-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: scanner <scanner@hive.kubestellar.io> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
β¦alth-10559 π hub: restore node stats for pull-only clusters via heartbeat health; neutral awaiting-heartbeat state
* π fix: do not claim dependency-blocked issues on kick The kick footer tells the agent 'Blocked by open dependencies β do NOT start these', but KickMessage.IssueRefs still carried those issues, so recordAgentKickClaims posted a π 'Claimed by agent scanner' comment on them every kick cycle (seen 4x each on hive#10598/#10599 while blocked on #10595). Filter blocked issues out of IssueRefs alongside in-flight ones. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com> * changelog: fragment for #10724 Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com> Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
β¦entry (#10728) The guide was published and reviewed under operator decision on #10515 (hive #10704 removed the in-page notice); documentation-map.md still carried the old caveat. Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
7ddd362 to
57e8e2a
Compare
Apply decision C: keep the Spek recheck config/types/endpoints on v6 but return 501 from triggerCampaignRecheck pending #10734, with recheck tests skipped accordingly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andy Anderson <andy@clubanderson.com> Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
57e8e2a to
322338e
Compare
- TestGovWorkSource_WavefrontValidation / TestGovWorkSource_ExternalRejectsLiteralToken: the merge nested the wavefront validation inside the external block and dropped the return after the external validation error; restore the early return and un-nest wavefront validation so rejected PUTs 400 without mutating config. - TestDashboardSectionTitlesMatchSidebarLabels / TestInceptionSidebarLabelsSpektacular: card title is now 'π‘ Inception (spektacular)' to match the sidebar label, and the section header is restored to v6's 'Project Inception Β· powered by Spektacular'. - TestIssueClaimsFeatureTooltip: tooltip says 'hive:claim marker comment' (the real marker in pkg/issueclaim; hive-claim is legacy). - TestNavbarStickyThreeZoneLayout: restore oc-topbar-center holding fleet-breaker-wrap and agent-navbar-upnext; close the nav-chip-group span the merge left open. - TestBackendSupportTiersAdvisorEntryCoversEveryBackend: add the openhands row (No) to the advisor lane table. - TestSleepRatchet: raise sleepBaseline 201β203 for sleeps carried in from already-merged v5 tests (merge-only bump). Signed-off-by: scanner <scanner@hive.kubestellar.io>
|
hive/awaiting-ci: pushed a fixup (8652255) for the 8 union test failures (worksource wavefront/external validation nesting, inception title/header, hive:claim tooltip, topbar three-zone center, openhands advisor doc row, sleep ratchet 201β203). CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
The forward-merge kept v6's older renderVersionDetails/renderVersionChip (typeof-guarded fallbacks, versionTrackingLabel) while carrying v5's version_provenance_ui_test.go, so TestVersionProvenanceRendering failed on the "2 behind"/"pinned a1b2c3d" assertions. Adopt v5's renderers and the v5 test as of the merged v5 commit (43d631f); pkg/dashboard passes under CI's shuffle seed 1791249651411000803. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
There was a problem hiding this comment.
The two red test shards (dashboard shuffle 1/2, rest 1/5) are one deterministic failure, and it is a merge-resolution regression rather than flake:
version_provenance_ui_test.go:34: version renderer failed: exit status 1
assert.ok(out.menu.includes('2 behind')) // actual: false
Mechanism. In fetchGitVersion, v6 computes a local statusText that becomes "2 behind" when commitsBehind is known (src/pkg/dashboard/static/index.html:27582 on this head, same as v6 :26176) and then hands that local to the renderers via window._lastVersionContext = { β¦, statusText: statusText, β¦ } (v6 :26198). This merge took v5's version of that line instead β statusText: versionStatusSummary(v, offeredUpgradeShort) (index.html:27604, from v5 :26669). versionStatusSummary returns 'upgrade available β b2c3d4e' for any behind: true payload and never reaches the N behind text, so the local at :27582 is now computed and discarded, and renderVersionDetails (which only reads ctx.statusText) no longer shows the commit count. The v6 test asserting '2 behind' (version_provenance_ui_test.go:117) was kept, so it fails. v6 tip a909f89 passes this test.
Fix. Either restore v6's resolution at index.html:27604 β statusText: statusText β which keeps v6's "N behind" menu row (v5's new renderVersionSurfaces/navbar indicator is unaffected by this one field), or, if dropping the count in favour of the v5 summary is intended under decision C, say so and update the assertion at version_provenance_ui_test.go:117. The former preserves v6 behaviour and is the one I'd expect for a forward-merge.
Scope note: I read only this failure and the version-rendering functions it touches, not the other 313 files. The probot DCO failure is the usual forward-merge false positive on others' commits and is unrelated.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Top up v6 with origin/v5 after #10738. Keep the v6 in-place Spek recheck and proxy-only discovery implementation from #10807/#10809; #10734 is closed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andy Anderson <andy@clubanderson.com>
Top up v6 with origin/v5 after #10738. Keep the v6 in-place Spek recheck and proxy-only discovery implementation from #10807/#10809; #10734 is closed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Andy Anderson <andy@clubanderson.com>
Closes #10590
Follow-up for option A: #10734
Resolution table
src/DockerfileGOOS/GOARCHon Go builds plus v6hive-admin-mcpbinary.src/cmd/hive/main.goresolveSpokeDashboardURL; v5 side was equivalent/commentary in the conflict.src/docs/api-reference.mdProjects cards,Throughput). Citation fixer not run locally becauseAGENTS.mdforbids local citation guards unless CI requests it.src/docs/integration-guide.md,src/docs/integrations/work-source-providers.md,src/docs/labels-and-control-signals.mdneeds-*labels.src/go.modgo.opentelemetry.io/otel/log.src/hive.yaml.example/src/pkg/config/runs_config*src/pkg/config/config.go/ split config filesopenhandsintobackends.go; retained v6 hub config comments.src/pkg/dashboard/api.go/api/feedback/nps/issueand/api/feedback/status; retained campaign recheck endpoint.src/pkg/dashboard/api_campaigns.go/src/pkg/knowledge/inception.gosrc/pkg/dashboard/campaign_recheck.gotriggerCampaignRecheckreturns 501 with a clear #10734 message; cadence tick is inert on v6.src/pkg/dashboard/api_campaigns_test.go,src/pkg/dashboard/recheck_discovery_test.got.Skipciting #10734.src/pkg/dashboard/stage_leases.gosrc/pkg/dashboard/static/index.html,version_provenance_ui_test.go,api_governor_features.gosrc/pkg/dashboard/webstatic/style_ratchet_test.gosrc/internal/testutil/sleep_ratchet_test.gosrc/pkg/hub/stable_promotion.gomustParseRFC3339; only v6health_verdict.gocopy remains.Recheck disabled on v6
Per #10590 decision C, the v5 Spek continuous convergence recheck and outward discovery model is not ported in this PR. Config keys, types, UI affordances, and endpoints remain present for compatibility, but manual/cadence recheck execution returns HTTP 501 until #10734 ports the feature onto v6's in-place campaign revision model. v6 must not ship a release until #10734 lands.
Validation
AGENTS.mdforbids localgo build,go test,go vet, and docs citation guard runs in this repository. Local checks run:gofmt -lon touched Go files: cleannode --check bin/contributor-relay.jsnode --check bin/contributor-relay.test.jssrc/pkg/dashboard/static/index.htmland rannode --check: cleanfunc mustParseRFC3339remains undersrc/pkg/hubgit diff --cached --check: cleanCoverage/package ratchets were not re-measured locally because package tests are forbidden for agents here; CI is the source of truth.