Skip to content

🐝 Hive Advisory Report #2364

New issue
New issue
Open
Open
🐝 Hive Advisory Report#2364
Labels
hive/advisoryPinned advisory report from Hive agentshive/selfreportCreated by Hive for agent-filed issue provenancehold

Description

@hivecommons-hive
hivecommons-hive
bot
opened on Jul 31, 2026

This issue collects advisory findings from Hive agents.

At lower ACMM levels, some agents work in advisory mode — they analyze code and post findings here but do not create issues or PRs. At higher levels, designated agents (e.g. quality) can open issues and PRs directly, while other agents remain advisory-only.

The governor posts periodic digest comments summarizing what advisory agents found.

Do not close this issue. It is a living document.

Affected hives (2):

Activity

  1. hivecommons-hive
    added
    hive/advisoryPinned advisory report from Hive agents
    on Jul 31, 2026
  2. github-actions
    added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Jul 31, 2026

  3. hivecommons-hive commented on Jul 31, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Jul 31, 2026 – with hivecommons-hive
    ContributorAuthor

    🐝 Advisory Digest — 2026-11-11 06:15 EST

    Automated code review findings from Hive agents. Each finding includes a file reference and suggested fix. This comment is updated periodically.

    Advice

    Frozen for governor mode IDLE until 2026-11-16 (next review in 5 day(s)). The list of recommendations is frozen; their numbers, items and links are recomputed on every digest.

    Counts quoted: governor actionable queue 0 PRs / 2 issues (what mode and cadence key on; excludes held, draft, in-review and human-gated items) — Overview chart 0 open PRs / 11 open issues (every open or held item across repo cards; the queue-health advice counts these).

    • Enable a disabled agent — The hive has spare capacity; enabling one disabled lane can increase useful throughput. (signals: mode=IDLE, disabled_agents=1)
    • Close what agents already finished — No longer applies: the signal that triggered this advice has cleared since the epoch began.

    Findings: 10

    💡 Showing top 10 findings (by severity). 11936 more exist. Set governor.advisory.show_all: true to see all.

    Severity Count
    🔴 critical 10

    🔴 CRITICAL (10)

    ☑️ Recently Closed — Fix Not Verified (10)

    Closed on an agent's word or a hive heuristic (a merged PR's title matching the finding, or the issues/PRs it cites closing). The hive did not re-check the condition, so it may still hold.

    Analyzed at hivecommons/hive@c771a5cf252d (branch v5) — the latest commit when this digest was generated. File references that no longer exist at this commit are flagged as outdated. Findings marked ⚠️ were computed at an older commit and have NOT been re-verified here.

    Updated 35 times · last 2026-11-11T11:16:04Z

  4. clubanderson commented on Aug 8, 2026

    @clubanderson
    clubanderson
    on Aug 8, 2026
    Member

    🔍 Scanner Advisory — 2026-08-08

    Stale Bead Reaped

    New Beads Created (11 new findings, linked to existing issues)

    🔴 Critical / Security (p0)

    Issue Finding Evidence
    #2877 Webhook kick endpoint HMAC validation optional — unauthenticated requests can trigger agent kicks POST /api/kick/{agent} behind auth middleware, but no HMAC signature check on webhook payloads per sec-check filing
    #2878 Dockerfile: su-exec.c fetched from mutable master branch, no checksum curl -sL https://raw.githubusercontent.com/ncopa/su-exec/master/su-exec.c then chmod u+s — SUID binary
    #2879 Dockerfile.hub: kubectl downloaded dynamically with no checksum curl -sLo kubectl "https://dl.k8s.io/release/$(curl stable.txt)/...kubectl" — version and binary both fetched at build time

    🟠 High (p1)

    Issue Finding Evidence
    #2880 All GitHub Actions use mutable major-version tags actions/checkout@v4, docker/setup-buildx-action@v3, docker/build-push-action@v6, etc. — no SHA pins
    #2881 Unpinned agent CLI packages ARG CLAUDE_CODE_VERSION=latest in Dockerfile; other backends unpinned per sec-check filing

    🟡 Medium / Quality (p2)

    Issue Finding
    #2882 No .github/dependabot.yml — CVE tracking absent for Go, npm, and Actions
    #2876 buildSecurity and dashboardAgentReviewCapable functions lack dedicated unit tests

    🔵 Low / Documentation (p3)

    Issue Finding
    #2871 No CONTRIBUTING.md at repo root — contributor workflow undocumented
    #2872 examples/kubestellar-fixer.md is absent from examples tree — broken reference
    #2873 No .github/ISSUE_TEMPLATE or PULL_REQUEST_TEMPLATE — contributors file freeform reports
    #2874 v2/proxy/ has no README — Node.js proxy architecture undocumented

    Ongoing Tracked Issues (no change)

    Filed by scanner agent (ACMM L4 — issues-only mode)

  5. hivecommons-hive commented on Aug 12, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Aug 12, 2026 – with hivecommons-hive
    ContributorAuthor

    🏗️ Architect Advisory — 2026-08-12

    PR #2715 Architecture Review: fix(integrated): harden hosted Visual Hive lifecycle

    Scope: +1,793/−138 across 42 files — lifecycle durability, governance delivery, proxy hardening.

    ✅ Architecture Strengths

    1. Fail-closed authorization — AuthorizeIssueOpen (manager.go:5127) enforces UID-based forge resistance: the file-system owner of the request file must match the declared agent identity. This closes the agent-impersonation vector that existed when agents could POST directly.

    2. Issue creation mediation — Direct POST /repos/*/issues is now a hard deny in proxy rules.go (new denyRules entry), forcing all issue creation through hive-open-issue → IssueRequestWatcher. This mirrors the existing PR creation pattern and ensures attribution + deduplication.

    3. TOCTOU-resistant file I/O — readAgentRequest (request_watcher_file.go) uses Lstat→Open→SameFile to prevent symlink-swap attacks in the group-writable request directory. Atomic writes via temp+rename on the result path.

    4. Content-addressable deduplication — agentFindingMarker hashes (repo, title, body) into an HTML comment marker embedded in the issue body. The watcher checks all open issues for this marker before creating, making retries idempotent.

    5. Immutable dispatch reconciliation — The controller validates every specialist dispatch envelope against its durable bead identity before advancing lifecycle state. Replays are idempotent; mutations are fail-closed.

    🟠 Architecture Concerns (High)

    1. Issue listing scalability — createOrReuseAgentIssue (issue_request_watcher.go:177-210) paginates ALL open issues in the target repo before creating. For repos with 1,000+ open issues, this could exhaust API rate limits or timeout. Consider caching open-issue markers or using the GitHub search API with the marker text.

    2. Fuzzy dedup in managed finding match — sameManagedFinding (issue_request_watcher.go) uses path overlap + term overlap heuristics. The threshold (1 path + 2 terms) could false-positive on repos with deep directory trees where multiple findings reference the same source file. This could suppress legitimate distinct findings.

    3. GraphQL createIssue regex bypass — graphQLCreateIssueRe (rules.go) matches createIssue\s*\( case-insensitively. A GraphQL alias like myAlias: createIssue(...) would still match, but field-level manipulation (e.g. embedding createIssue in a comment or string) could evade it. The regex approach is reasonable but not hermetic.

    🟡 Architecture Concerns (Medium)

    1. No backpressure on issue request polling — The watcher polls every 10s (issueRequestPollInterval). If request processing is slow (e.g., GitHub rate-limited), multiple poll cycles could process the same file concurrently. The current rename-on-complete pattern mitigates this, but there's no explicit file lock.

    2. Lifecycle state machine complexity — The FindingLifecycle struct (lifecycle.go) has 13 status values and growing. The state transitions are validated via the controller's locked reconciliation, but there's no formal state machine definition or transition diagram. This makes it hard to verify completeness of error handling across all transitions.

    3. Controller mutex scope — The controller holds controller.mu.Lock() for the entire duration of operations like CompleteSpecialistPullRequest and RetireSpecialistPullRequest, including bead store I/O. Under load, this could serialize all specialist completions.

    🔵 Observations (Low)

    1. Entrypoint config preservation is well-structured: runtime config is read from PVC, ConfigMap is seed-only, and hub-managed keys are explicitly preserved during merges.

    2. Test coverage — Tests appear meaningful (not just coverage padding): issue_request_watcher_test.go tests dedup, authz denial, and managed-finding matching. controller_test.go tests idempotent replay.

    📐 Architectural Recommendation

    The issue request watcher pattern is architecturally sound and consistent with the existing PR request watcher. The main scaling risk is the full-repo issue scan. Recommend adding a state:open + marker search via GitHub search API as a fast path, falling back to pagination only when search returns 0 results (to handle indexing lag).

  6. clubanderson
    removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Aug 14, 2026

  7. clubanderson commented on Aug 14, 2026

    @clubanderson
    clubanderson
    on Aug 14, 2026
    Member

    Removed the help wanted label. This is a standing living document, not actionable work — its own body says "Do not close this issue. It is a living document." and it already carries hive/advisory ("Pinned advisory report from Hive agents").

    help wanted was causing it to surface in triage sweeps as if it were a claimable task. hive/advisory alone is the correct signal, and sweeps should treat it as exempt alongside the other tracker issues.

  8. Danathar commented on Aug 15, 2026

    @Danathar
    Danathar
    on Aug 15, 2026
    Contributor

    Advisory finding: the digest is losing half its own report to duplicate flooding

    Working this tracker's findings today, the most actionable problem turned out to be the digest comment itself. The 2026-08-15 15:08 EDT digest ends with:

    ⚠️ Digest truncated: 174962 → 65196 characters (GitHub limit: 65536)

    It claims 334 findings (16 critical / 132 high / 136 medium / 50 low) but renders only CRITICAL and HIGH — truncateDigest (v2/pkg/github/advisory.go:209) cuts from the bottom, so all 136 medium and 50 low findings are absent from the report. About 40 of the rendered HIGH entries are one signal (pr-verifier calling a deleted reusable workflow) re-filed with cosmetic wording drift; BuildDigestFromBeads deduped on the exact title, so every paraphrase counted as new.

    Fix opened as #3927: normalized dedup key (digit runs and punctuation folded, words never merged) plus a per-(agent, finding-type) render cap with an explicit "…plus N more" collapse line, so lower-severity sections survive and the true counts stay visible.

    Triage of the rest of this digest, for whoever reads it next

    Most remaining entries are already resolved — the digest is showing healed findings because the beads were never closed:

    Finding Actual state on v4 @ d89121f5
    reclaimExpiredLeases missing pendingToken/credentialDelivered cleanup Fixed — contribute_ws.go:2962-2963 clears both, tagged #2675
    impersonate_cookie.go (135 lines) has zero tests Fixed — impersonate_cookie_test.go exists
    drift.go pure functions have zero unit tests Fixed — drift_pure_functions_test.go
    copilot_scanner.go has zero tests Fixed — copilot_scanner_test.go
    api_leaderboard_style.go untested Fixed — three test files
    ssrf_guard.go noRedirectToPrivate untested Fixed — ssrf_guard_test.go
    github_proxy.go utility functions untested Fixed — github_proxy_util_test.go
    ValidateGitSourceURL doesn't reject private/loopback Fixed — gitsource.go:289-296 rejects, opt-out via HIVE_ALLOW_PRIVATE_GIT_SOURCE; covered by gitsource_ssrf_test.go + gitsource_f8_redirect_test.go
    handleConfigProvenance defaults empty X-Hive-Role to owner Fixed — requireOwnerRole (api.go:1366) requires both a non-empty owner role and the verified header; RoleAtLeast returns false for an unknown/empty role
    Dockerfile su-exec / kubectl unchecksummed (#2878/#2879) Issues closed
    The ~40 pr-verifier.yml ci-failure entries Same signal, now collapsed by #3927

    Still live and worth someone's time: v2/pkg/agent/permissions_watcher.go — the digest calls it 0% covered; that is now only partly true (seams_coverage_test.go and authprobe_test.go exercise ensureWatchedDirs, fixPermissions, fixEntry, fixBobStateDirGroupWrite), but sharedRepoClones and StartPermissionsWatcher still have no direct coverage.

    Suggestion for the digest loop: findings whose beads are stale enough to be already-fixed are the second-largest source of noise here after the duplicates. The PathStale mechanism (#3704) catches moved files but not fixed code — a periodic bead-reaping pass, like the scanner did for #2318, would keep this report honest.

  9. Danathar commented on Aug 15, 2026

    @Danathar
    Danathar
    on Aug 15, 2026
    Contributor

    Correction to my comment above, before anyone acts on it: I claimed the dedup half of #3927 addresses the duplicate flood. I then tested it against the real data and it mostly does not.

    I extracted the 37 pr-verifier titles from the live digest and ran them through the new normalized key: 37 titles → 36 distinct keys. They are genuine paraphrases ("broken:", "failing 100% —", "fails on every PR:"), not run-number drift, so folding digits and punctuation barely touches them. The normalization is still strictly better than the exact-title check it replaces, but it is not what fixes this.

    The render cap is what fixes it: same 37 titles through the new renderer produce 5 entries plus one explicit "…plus 32 more" line (1,055 chars for that group, vs. thousands today). PR body updated with the measurement.

  10. clubanderson
    added 6 commits that reference this issue on Aug 17, 2026

    🐛 fix(advisory): collapse near-duplicate findings in the advisory dig…

    e555a8f

    fix(advisory): stop near-duplicate findings from flooding the digest …

    d167342

    fix(ci): notify on cancelled/timed-out v2 Tests runs, not just failur…

    73fc542

    🐛 fix(contribute): honour non-closing PR references so in-flight work…

    5bc7eec

    fix(advisory): rank live findings above since-removed ones in the dig…

    a08dd80

    fix(advisory): rank live findings above since-removed ones in the dig…

    ff68dc6

  11. 11 remaining items

  12. clubanderson
    added a commit that references this issue on Sep 18, 2026

    🌱 cmd/hive: extract advisory digest pin/publish seams from runEvalCycle

    8b4d88f

  13. hivecommons-hive commented on Oct 19, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 19, 2026 – with hivecommons-hive
    ContributorAuthor

    Also seen on hosted-available-oke-11-placeholder-r05x (v5.186.3, —) at 2026-10-19T13:49:34Z — class advisory_post_failed, 1 in 11m44s

    advisory digest post failed: updating advisory digest comment on hive#2364: PATCH https://api.github.com/repos/hivecommons/hive/issues/comments/5145759745: 502 Server Error []

  14. hivecommons-hive
    added
    hive/selfreportCreated by Hive for agent-filed issue provenance
    on Oct 19, 2026
  15. github-actions
    added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 19, 2026

  16. hivecommons-hive commented on Oct 19, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 19, 2026 – with hivecommons-hive
    ContributorAuthor

    Cleared on hosted-available-oke-11-placeholder-r05x (v5.186.3) at 2026-10-19T13:57:43Z — the condition is no longer observed there. Leaving the issue open for a human to confirm the fix.

  17. clubanderson
    added
    hold
    on Oct 19, 2026

  18. hivecommons-hive commented on Oct 19, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 19, 2026 – with hivecommons-hive
    ContributorAuthor

    Also seen on hosted-available-oke-08-placeholder-xf07 (v5.186.4-982-gd57def469, —) at 2026-10-19T17:39:32Z — class advisory_post_failed, 1 in 9m57s

    advisory digest post failed: updating advisory digest comment on spektacular#30: PATCH https://api.github.com/repos/hivecommons/spektacular/issues/comments/5169494026: 500 []

  19. hivecommons-hive commented on Oct 19, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 19, 2026 – with hivecommons-hive
    ContributorAuthor

    Cleared on hosted-available-oke-08-placeholder-xf07 (v5.186.4-982-gd57def469) at 2026-10-19T17:49:30Z — the condition is no longer observed there. Leaving the issue open for a human to confirm the fix.

  20. hivecommons-hive commented on Oct 21, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 21, 2026 – with hivecommons-hive
    ContributorAuthor

    Also seen on hosted-available-oke-11-placeholder-r05x (v5.186.4-162-g2a9e3f583, —) at 2026-10-21T16:01:19Z — class advisory_post_failed, 1 in 21m40s

    advisory digest post failed: posting advisory digest to hive#2364: Post "https://api.github.com/repos/hivecommons/hive/issues/2364/comments": github pacing: slot would miss request deadline: context deadline exceeded

  21. hivecommons-hive commented on Oct 21, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 21, 2026 – with hivecommons-hive
    ContributorAuthor

    Cleared on hosted-available-oke-11-placeholder-r05x (v5.186.4-162-g2a9e3f583) at 2026-10-21T16:11:33Z — the condition is no longer observed there. Leaving the issue open for a human to confirm the fix.

  22. lovelaceyrae11 commented on Oct 21, 2026

    @lovelaceyrae11
    lovelaceyrae11
    on Oct 21, 2026

    Hi @hivecommons-hive[bot] and team,

    I saw your advisory report and tracking regarding 🐝 Hive Advisory Report in hivecommons/hive (#2364). In multi-agent swarm topologies, unvalidated handoffs and recursive retry loops frequently burn up to 62.4% of token budgets before failing mid-pipeline.

    We ran a pre-flight topological diagnostic against this failure pattern using the Castleberry 127-Node Sovereign Lattice (guardrail_kit):

    • Target Vector: hivecommons/hive (targeted_high_degree_failure & Step-0 schema bypass)
    • Pre-Flight SHA-256 Audit Preview: 394affd23a8aa952017143bd... [LOCKED - COMMERCIAL GATE]

    You can run a free live pre-flight diagnostic on our portal, unlock the Certified SHA-256 Pipeline & SPOF Remediation Report ($499), or grab an Annual Commercial Exemption License ($5,000/yr) directly here:
    👉 Live Diagnostic Portal: https://lovelaceyrae11.github.io/lovelaceyrae.github.io/
    👉 Instant $499 Certified Audit Checkout: https://buy.stripe.com/00w4gz1Pu3aFdcQbyIgA801

    Best regards,
    Lacey Rae Castleberry
    Architect, Castleberry Bloom Sovereign Systems

  23. hivecommons-hive commented on Oct 26, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 26, 2026 – with hivecommons-hive
    ContributorAuthor

    Also seen on hosted-available-oke-11-placeholder-r05x (v5.186.4-589-gf25637ccf, —) at 2026-10-26T18:45:02Z — class advisory_post_failed, 1 in 7m3s

    advisory digest post failed: updating advisory digest comment on hive#2364: PATCH https://api.github.com/repos/hivecommons/hive/issues/comments/5145759745: 502 Server Error []

  24. hivecommons-hive commented on Oct 26, 2026

    @hivecommons-hive
    hivecommons-hiveBot
    on Oct 26, 2026 – with hivecommons-hive
    ContributorAuthor

    Cleared on hosted-available-oke-11-placeholder-r05x (v5.186.4-589-gf25637ccf) at 2026-10-26T18:50:26Z — the condition is no longer observed there. Leaving the issue open for a human to confirm the fix.

  25. hanthor
    removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 28, 2026
  26. hivecommons-hive
    added a commit that references this issue on Nov 9, 2026

    🐛 advisory digest: one marker comment, rewrite a changed digest at mo…

    482c854
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    hive/advisoryPinned advisory report from Hive agentshive/selfreportCreated by Hive for agent-filed issue provenancehold

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions