fix: accept omitted liveHashes field in AccountInfoQuery test - #688
Conversation
Signed-off-by: Fantomasa <ivailoinfo@gmail.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe account-info specification and test now support SDKs that omit the retired ChangesAccount-info liveHashes handling
Estimated code review effort: 2 (Simple) | ~5 minutes Mergeability Score: ⚪ Minimal · up to This change updates the account-information test and specification to accept SDKs that omit the retired liveHashes field; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
AccountInfoQuerytest(#19) Query account info and verify liveHashes is returnedfails against JS SDK v2.87.0:Live hashes are a retired network feature. hiero-ledger/hiero-sdk-js#4269 (shipped in v2.87.0) removed the long-deprecated live hash API from the SDK and, with it, the
liveHashesfield from the TCK server'sgetAccountInforesponse. Other SDKs still expose the field, so the TCK must accept both shapes.This PR applies the same pattern as #673: the test validates that
liveHashesis an array when the field is present and accepts its absence for SDKs that removed the retired API. The spec document is updated to match.First observed in the consensus-node XTS dry run validating hiero-ledger/hiero-consensus-node#26820 (SDK TCK Regression panel, JS SDK v2.87.0): 2396 tests, 2162 passed, 1 failed, the only failure being this assertion.
Related Issues
Summary by CodeRabbit
Documentation
liveHashesfield is omitted or returned.Tests
liveHashes.liveHashesas an array when provided.