Skip to content

ci: bump JS SDK to v2.87.0 and TCK to v0.12.4 for the SDK TCK Regression panel - #26820

Open
Fantomasa wants to merge 2 commits into
hiero-ledger:mainfrom
Fantomasa:bump-tck-panel-js-sdk-2.87.0
Open

ci: bump JS SDK to v2.87.0 and TCK to v0.12.4 for the SDK TCK Regression panel#26820
Fantomasa wants to merge 2 commits into
hiero-ledger:mainfrom
Fantomasa:bump-tck-panel-js-sdk-2.87.0

Conversation

@Fantomasa

@Fantomasa Fantomasa commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Description

Bumps the SDK TCK Regression panel pins in .github/workflows/support/citr/.citr-env:

  • js-sdk-version: v2.85.0 -> v2.87.0
  • tck-version: v0.12.3 -> v0.12.4

The js-sdk-version pin has not moved since it was introduced in #25962 (June 17). Since then the JS SDK has shipped 2.86.1, 2.86.2 and 2.87.0 (released 2026-08-12), so the panel was validating an SDK two minor versions behind.

Why the TCK bump is included

The first validation dry run (31678180086) against JS SDK v2.87.0 produced exactly one failure out of 2396 tests: AccountInfoQuery (#19) verify liveHashes is returned. Live hashes are a retired network feature and hiero-ledger/hiero-sdk-js#4269 (shipped in v2.87.0) removed the deprecated API, so the TCK server no longer returns the field. The stale expectation was fixed in hiero-ledger/hiero-sdk-tck#688 and released as TCK v0.12.4, which this PR pins.

Compatibility notes

Validation

Triggering the XTS dry run requires repository admin rights, so I could not run it myself. A maintainer can validate by running 001: [USER] CITR XTS Dry Run with ref pointed at this branch (the run reads .citr-env from the ref), with only the SDK TCK Regression panel enabled.

Related Issues

Signed-off-by: Fantomasa <ivailoinfo@gmail.com>
@Fantomasa
Fantomasa requested a review from a team as a code owner August 13, 2026 06:38
@Fantomasa
Fantomasa requested a review from brunodam August 13, 2026 06:38
@lfdt-bot

lfdt-bot commented Aug 13, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #26820   +/-   ##
=========================================
  Coverage     70.42%   70.42%           
  Complexity    11656    11656           
=========================================
  Files          2583     2583           
  Lines        108199   108199           
  Branches      12105    12104    -1     
=========================================
  Hits          76204    76204           
  Misses        28013    28013           
  Partials       3982     3982           

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Fantomasa

Copy link
Copy Markdown
Contributor Author

The validation dry run (31678180086, thanks @AlexKehayov) came back with a single failure out of 2396 tests:

AccountInfoQuery > (#19) Query account info and verify liveHashes is returned
AssertionError: expected { accountId: '0.0.1466', ...(22) } to have property 'liveHashes'

This is a stale TCK expectation, not an SDK or consensus-node problem: live hashes are a retired feature and JS SDK v2.87.0 removed the deprecated API (hiero-ledger/hiero-sdk-js#4269), so the TCK server no longer returns the field. Fix is up in hiero-ledger/hiero-sdk-tck#688.

Plan: once that merges I will cut a TCK release containing it and push a commit here bumping tck-version alongside js-sdk-version, then this PR can be re-validated with a fresh dry run. Marking as draft until then.

@Fantomasa
Fantomasa marked this pull request as draft August 13, 2026 08:03
Signed-off-by: Fantomasa <ivailoinfo@gmail.com>
@Fantomasa Fantomasa changed the title ci: bump JS SDK version to v2.87.0 for the SDK TCK Regression panel ci: bump JS SDK to v2.87.0 and TCK to v0.12.4 for the SDK TCK Regression panel Aug 13, 2026
@Fantomasa
Fantomasa marked this pull request as ready for review August 13, 2026 08:24
@Fantomasa

Copy link
Copy Markdown
Contributor Author

TCK v0.12.4 is released with the liveHashes fix (hiero-ledger/hiero-sdk-tck#688) and this PR now bumps tck-version alongside js-sdk-version. Un-drafted. @AlexKehayov could you re-run the dry run against this branch when you get a chance? Only the failing AccountInfoQuery (#19) assertion changed on the TCK side, so a green SDK TCK panel is the expected outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants