Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
target_sha:
description: Reviewed protected-finalization target SHA
required: true
default: '0000000000000000000000000000000000000000'
default: '835b81be1ff0ba7aa0ec23c9a7b518d4ade3dfaa'
type: string
package_coordinate:
description: Fixed disposable GitHub Packages base coordinate
Expand All @@ -26,7 +26,7 @@ concurrency:
cancel-in-progress: false

env:
WDV3_ACCEPTANCE_TARGET_SHA: '0000000000000000000000000000000000000000'
WDV3_ACCEPTANCE_TARGET_SHA: '835b81be1ff0ba7aa0ec23c9a7b518d4ade3dfaa'
WDV3_ACCEPTANCE_PACKAGE_COORDINATE: '@hcoona/hcoona-release-smoke-npm@0.0.0-wdv3-acceptance.13'
WDV3_ACCEPTANCE_CONFIRMATION: I_ACCEPT_DISPOSABLE_GITHUB_PACKAGES_PROBES_RETRY_4
WDV3_ACCEPTANCE_REF: refs/heads/main
Expand Down
21 changes: 21 additions & 0 deletions .testagent/plan.md
Original file line number Diff line number Diff line change
Expand Up @@ -6318,3 +6318,24 @@ reuse of consumed acceptance coordinates.
the four-file allowlist and append-only notes.

<!-- END APPEND: 2026-08-28-pr608-retry-4-terminal-fixed-identity-plan -->

<!-- BEGIN APPEND: 2026-08-28-wdv3-acceptance-retry-4-finalization-plan -->

## Retry-4 protected-finalization plan

1. Change only target-pinned workflow and Governance contracts to require
preparation merge
`835b81be1ff0ba7aa0ec23c9a7b518d4ade3dfaa`.
2. Preserve executable rejection of zero and wrong dispatch inputs, exact
rejected-dispatch terminal identity, complete real-registry Governance
admission, historical profile replay, and cross-profile rejection.
3. Run the two focused contract modules and classify the intentional RED
failures. They must arise only because the workflow default/environment
and registered Governance target remain the preparation zero sentinel.
4. Implement only those three production target bindings, update current
authoritative state documents, and run focused then complete validation.
5. Run repository gates and multi-reviewer OCR review with atomic independent
TP/FP adjudication before commit, push, and the non-bypassed finalization
PR.

<!-- END APPEND: 2026-08-28-wdv3-acceptance-retry-4-finalization-plan -->
34 changes: 34 additions & 0 deletions .testagent/research.md
Original file line number Diff line number Diff line change
Expand Up @@ -5756,3 +5756,37 @@ validation-failure branch. No production, workflow, or normative-document edit
is in scope.

<!-- END APPEND: 2026-08-28-pr608-retry-4-terminal-fixed-identity-research -->

<!-- BEGIN APPEND: 2026-08-28-wdv3-acceptance-retry-4-finalization-research -->

## Retry-4 protected-finalization target research

Preparation PR #608 rebase-merged as
`835b81be1ff0ba7aa0ec23c9a7b518d4ade3dfaa`. Fresh authenticated preflight
confirmed that exact `main`, green post-merge checks, no nonterminal Actions
runs, active retry-4 workflow identity with zero runs, absent acceptance refs,
absent Environment, and absent `.13` through `.16` package versions and npm
tags. Environment `workflow-delivery-v3-buddy-smoke-acceptance-retry-4` was
then created as ID `20772100445` with sole reviewer `hcoona` / `712433`,
`prevent_self_review: false`, and one custom branch policy for `main`; readback
still showed zero workflow runs and deployments.

The immutable reviewed target is the preparation merge SHA, not a finalization
commit. The bounded tests-first scope is:

- the retry-4 workflow contract, which must bind both workflow target
literals to the preparation merge, execute the fixed guard against the real
finalized constant, reject zero and wrong dispatch values, and retain fixed
terminal identity after rejected validation;
- the Governance contract, which must bind the registered retry-4 profile to
the preparation merge, preserve zero-sentinel rejected-dispatch admission,
admit complete finalized evidence through the real registry, and keep
cross-profile substitutions closed.

The only expected production gaps are the two zero workflow target literals
and the zero retry-4 Governance profile target. Historical retry-1 through
retry-3 profiles, `.13` through `.16` coordinates/tags, confirmation digest,
workflow/Environment identity, permissions, DAG, first-attempt guard, and
normal Live exclusion remain unchanged.

<!-- END APPEND: 2026-08-28-wdv3-acceptance-retry-4-finalization-research -->
98 changes: 98 additions & 0 deletions .testagent/status.md
Original file line number Diff line number Diff line change
Expand Up @@ -10002,3 +10002,101 @@ No external GitHub Environment, acceptance ref, workflow dispatch, package,
tag, or Live mutation occurred during this closure.

<!-- END APPEND: 2026-08-28-pr608-terminal-closure-final-unstaged-gate -->

<!-- BEGIN APPEND: 2026-08-28-wdv3-acceptance-retry-4-finalization-red -->

## Retry-4 protected-finalization tests-first RED

Preparation PR #608 rebase-merged without bypass as
`835b81be1ff0ba7aa0ec23c9a7b518d4ade3dfaa`; its post-merge CI and CodeQL
passed. Fresh authenticated preflight passed and was sealed in the session
handoff package. Environment
`workflow-delivery-v3-buddy-smoke-acceptance-retry-4` now exists as ID
`20772100445` with sole reviewer `hcoona` / `712433`, self-review permitted,
and one custom branch policy for `main`. Readback showed zero workflow runs
and deployments.

The delegated Test Generator completed bounded research but could not write in
its execution context, so the documented inline fallback performed the same
Research -> Plan -> Implement sequence. Only the two target-pinned contract
modules and append-only research/plan notes changed before RED execution.

Focused retry-4 workflow and Governance contracts produced the intended
`21 failed, 362 passed` state:

- five workflow-contract failures bind the still-zero dispatch default and
workflow target, the finalized guard success path, rejected wrong-input
control, and terminal evidence through real Governance admission;
- sixteen Governance failures bind the still-zero registered retry-4 target,
complete real-registry admission, and all fourteen cross-profile
substitutions.

Every failure is caused by one of the three planned production gaps: the two
zero workflow target literals or the zero retry-4 Governance profile target.
No unrelated failure, workflow dispatch, deployment, acceptance ref, package,
tag, or Live mutation occurred.

<!-- END APPEND: 2026-08-28-wdv3-acceptance-retry-4-finalization-red -->

<!-- BEGIN APPEND: 2026-08-28-wdv3-acceptance-retry-4-finalization-green -->

## Retry-4 protected-finalization implementation

The production change is limited to the three planned target bindings:

- workflow dispatch default:
`835b81be1ff0ba7aa0ec23c9a7b518d4ade3dfaa`;
- workflow `WDV3_ACCEPTANCE_TARGET_SHA`: the same preparation merge;
- registered retry-4 Governance profile target: the same preparation merge.

Target-pinned contracts now execute the finalized fixed-input guard, reject
zero and wrong dispatch values, retain the fixed finalized identity after
rejected validation, admit complete `.13` through `.16` evidence through the
real Governance registry, preserve zero-sentinel rejected-dispatch admission,
and reject retry-3/retry-4 field substitution.

Validation:

- focused workflow and Governance contracts: `383 passed`;
- focused Adapter, Buddy topology, workflow, retirement, and Governance suite:
`806 passed in 35.94s`;
- complete v3 suite: `3837 passed in 463.57s`;
- scoped Ruff, Ruff format, and Pyrefly: passed;
- Actionlint: passed;
- Prettier and markdownlint across the five authoritative wiki pages: passed;
- unstaged HK over the 12-file finalization diff: passed, including its
managed `3837 passed` v3 suite;
- exact target distribution: two workflow literals and one Governance
literal; the four workflow zero literals remain only the two validation
guards and two terminal fallback sentinels.

Pseudo-mutation review found the exact-target assertions kill zero, wrong-SHA,
default/environment disagreement, Governance-registry mismatch, finalization-
commit substitution, retry-3 field substitution, and loss of rejected-dispatch
identity mutations. Assertion-quality review found no assertion-free,
trivial-only, or self-referential changed test; the contracts combine exact
equality, negative, exception, subprocess outcome, canonical deep-structure,
and mutation-surface assertions. No additional test gap was identified.

The only external mutation remains authorized Environment creation. No
workflow dispatch, deployment, acceptance ref, package, tag, or Live mutation
has occurred.

<!-- END APPEND: 2026-08-28-wdv3-acceptance-retry-4-finalization-green -->

<!-- BEGIN APPEND: 2026-08-28-wdv3-acceptance-retry-4-finalization-review -->

## Retry-4 protected-finalization review correction

Independent workflow/test and Governance/test reviewers reported
`No findings.` The documentation/state reviewer found one authority gap: the
current LLD required finalization to merge before dispatch but did not repeat
that the merge must occur without bypass and that a fresh exact post-merge
preflight must pass before either acceptance-ref creation or dispatch.

An independent adjudicator classified the finding as a blocking true positive.
The LLD now states both existing hard gates without changing any other
authority or system boundary. The corrected documentation scope returns to a
fresh review, whose reviewer reported `No findings.`

<!-- END APPEND: 2026-08-28-wdv3-acceptance-retry-4-finalization-review -->
30 changes: 16 additions & 14 deletions docs/wiki/analyses/workflow-delivery/v3/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -229,20 +229,22 @@ Next:
1. preserve all three attempts and their exact evidence as unsuccessful
historical replay; do not infer acceptance from destination state or the
new diagnostics;
2. treat preparation PR #608 as a prerequisite: no later phase may begin
unless it has merged without bypass. It carries the closed `.13`-`.16`
profile, retry-4 workflow and Environment identity, and exact confirmation,
but keeps the target at 40 zeroes so validation stops before review or
mutation. The work started from freshly fetched `origin/main@bcf47e2d`;
`bf174897` remains implementation provenance only;
3. after preparation merges, revalidate the current principal, owner, `main`,
ruleset, checks, open-PR drift, runs, deployments, refs, workflow identity,
Environment, package versions, and tags. Only then create the fresh
protected retry-4 Environment;
4. open a separate finalization PR that changes the workflow target default and
constant, Governance profile target, and target-pinned tests to the
preparation merge SHA. The reviewed target is the preparation merge, not the
finalization commit;
2. record preparation PR #608 as rebase-merged without bypass at
`835b81be1ff0ba7aa0ec23c9a7b518d4ade3dfaa`. It carries the closed
`.13`-`.16` profile, retry-4 workflow and Environment identity, and exact
confirmation. The work started from freshly fetched
`origin/main@bcf47e2d`; `bf174897` remains implementation provenance only;
3. preserve the fresh authenticated preflight: principal `hcoona` / `712433`,
exact `main@835b81be`, active ruleset and workflow identity, green checks,
no nonterminal or retry-4 runs, no deployments or acceptance refs, and
absent `.13`-`.16` versions and tags. Environment ID `20772100445` has sole
required reviewer `hcoona`, self-review permitted, and sole deployment
branch `main`;
4. keep the separate protected-finalization change limited to the workflow
target default and constant, Governance profile target, target-pinned
tests, and authoritative state documents. Every target binds the preparation
merge SHA above, not a finalization commit. The finalization PR must merge
without bypass before any dispatch;
5. after finalization merges without bypass, run a fresh exact preflight. Only
if it passes may any acceptance ref be created or the single
`run_attempt == 1` package-mutation attempt be dispatched; stop for
Expand Down
38 changes: 20 additions & 18 deletions docs/wiki/analyses/workflow-delivery/v3/agent-handoff.md
Original file line number Diff line number Diff line change
Expand Up @@ -243,27 +243,29 @@ If it conflicts with the
later reviewed successor that contains it. Historical local branches and
attempt refs are cleanup or reconciliation inputs only; do not dispatch,
resume, or use them as work bases.
- Preparation PR #608 now carries the tests-first fourth profile without
operating it. The closed profile uses base `.13`: absent/exact `.13`,
identical-race `.14`, differing-race `.15`, and lost-response `.16`, with
tags `wdv3-acceptance-13` through `wdv3-acceptance-16`; workflow
- Preparation PR #608 rebase-merged without bypass as
`835b81be1ff0ba7aa0ec23c9a7b518d4ade3dfaa`. The closed fourth profile uses
base `.13`: absent/exact `.13`, identical-race `.14`, differing-race `.15`,
and lost-response `.16`, with tags `wdv3-acceptance-13` through
`wdv3-acceptance-16`; workflow
`.github/workflows/workflow-delivery-v3-buddy-smoke-acceptance-retry-4.yml`;
Environment `workflow-delivery-v3-buddy-smoke-acceptance-retry-4`; and
confirmation
`I_ACCEPT_DISPOSABLE_GITHUB_PACKAGES_PROBES_RETRY_4`. The Governance and
workflow target remains exactly 40 zeroes, so fixed-input validation fails
before Environment review or either package-write probe. The complete v3
suite passes 3,837 tests, local HK gates pass, and multi-reviewer review
converged to no findings after independent adjudication and repair. No
Environment, acceptance dispatch, package or tag mutation, or acceptance
ref was created. PR #608 is the preparation carrier; no later phase may
begin unless it has merged without bypass. Once that prerequisite is
satisfied, revalidate external state and create the fresh protected
Environment before a separate finalization PR pins the workflow and
Governance profile to the preparation merge SHA. The finalization PR must
also merge without bypass and a fresh exact preflight must still pass before
creating any acceptance ref or dispatching the single `run_attempt == 1`
attempt. Subsequent explicit user authorization covers the bounded
`I_ACCEPT_DISPOSABLE_GITHUB_PACKAGES_PROBES_RETRY_4`. Preparation validation
passed all 3,837 v3 tests, local HK gates, independent review/adjudication,
required checks, post-merge CI, and CodeQL.
Fresh authenticated preflight then confirmed principal `hcoona` / `712433`,
exact `main@835b81be`, active ruleset and retry-4 workflow identity, no
nonterminal or retry-4 workflow runs, no deployments or acceptance refs,
and absent `.13`-`.16` versions and npm tags. The protected Environment is
provisioned as ID `20772100445` with sole required reviewer `hcoona`,
self-review permitted, and sole deployment branch `main`. The separate
finalization change binds the workflow and Governance profile to the exact
preparation merge SHA above, not a finalization commit. It must merge
without bypass and a fresh exact preflight must still pass before creating
any acceptance ref or dispatching the single `run_attempt == 1` attempt. No
workflow dispatch, deployment, acceptance ref, package, or tag mutation has
occurred. Subsequent explicit user authorization covers the bounded
acceptance-only repair/retry loop through genuine success, reconciliation,
cleanup, and authoritative closure. Normal Live activation and
`live_enabled: true` remain a separate production decision and are not
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1670,16 +1670,21 @@ Only probe jobs declare `packages: write`; no PAT or `id-token: write` exists.
The workflow top-level permissions are `{}`. Validation and evidence-capture
jobs declare only `contents: read`; each probe job declares `contents: read`
plus `packages: write`. Unspecified permissions are none.
The dedicated retry-3 acceptance Environment was provisioned for the consumed
attempt with sole required reviewer `hcoona`, self-review permitted for the
single-operator topology, and sole deployment branch `main`. It was not either
normal Buddy Environment and was deleted after the unsuccessful run. Cleanup
PR #600 removed the temporary workflow source and workflow-only contract; the
numeric workflow identity is `deleted`. The retained historical workflow
evidence emits only Governance acceptance
evidence bound to workflow/run/target/fixed coordinate, dependency outcomes,
available probe results, and complete/incomplete/unknown mutation
classification. It cannot create Release Intent,
The dedicated retry-3 acceptance Environment was deleted after its consumed
unsuccessful attempt; cleanup PR #600 removed its temporary workflow source
and workflow-only contract, and its numeric workflow identity is `deleted`.
For retry 4, preparation PR #608 merged as
`835b81be1ff0ba7aa0ec23c9a7b518d4ade3dfaa`. Environment ID `20772100445`
has sole required reviewer `hcoona`, self-review permitted for the
single-operator topology, and sole deployment branch `main`. It is not either
normal Buddy Environment. Protected finalization binds the workflow and
Governance profile to the preparation merge SHA and must merge without bypass.
After that merge, a fresh exact preflight must pass before any acceptance ref
is created or the single authorized attempt-1 dispatch occurs. The workflow
emits only Governance acceptance evidence bound to
workflow/run/target/fixed coordinate, dependency outcomes, available probe
results, and complete/incomplete/unknown mutation classification. It cannot
create Release Intent,
Product/Execution/Attempt/Simulation identity, Authorization Record, Receipt,
or live Release history.

Expand Down
18 changes: 18 additions & 0 deletions docs/wiki/log.md
Original file line number Diff line number Diff line change
Expand Up @@ -2383,3 +2383,21 @@ Updated the CI affected-validation LLD to describe published runner-family artif
- Recorded 3,837 passing v3 tests and a successful unstaged HK gate. The
follow-up remains preparation-only: no Environment, acceptance ref,
workflow dispatch, package, tag, or Live mutation occurred.

## [2026-08-28] query | Finalize destination acceptance retry 4

- Rebase-merged preparation PR #608 without bypass as
`835b81be1ff0ba7aa0ec23c9a7b518d4ade3dfaa`; post-merge CI and CodeQL passed.
- Fresh authenticated preflight confirmed exact principal, owner, `main`,
ruleset, checks, open-PR drift, runs, deployments, refs, workflow identity,
and absent `.13`-`.16` package versions and retry-4 npm tags.
- Provisioned Environment
`workflow-delivery-v3-buddy-smoke-acceptance-retry-4` as ID `20772100445`
with sole required reviewer `hcoona`, self-review permitted, and sole
deployment branch `main`.
- Bound the protected-finalization workflow, Governance profile, and contracts
to the preparation merge SHA. Finalization must merge without bypass before
the single authorized attempt-1 dispatch, and another fresh exact preflight
must pass before any acceptance ref or dispatch.
- No workflow dispatch, deployment, acceptance ref, package, tag, or Live
mutation occurred.
Loading
Loading