ci(workflow-delivery): finalize destination acceptance retry 4 - #609
Merged
hcoona merged 1 commit intoAug 28, 2026
Merged
Conversation
Bind the retry-4 workflow and Governance profile to the reviewed preparation merge, preserve rejected-dispatch safeguards, and record the protected Environment boundary. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
It activates a one-shot package-writing workflow whose safety depends on protected external state and a fresh post-merge preflight.
Pull request overview
Finalizes retry-4 destination acceptance by pinning the workflow and Governance profile to PR #608’s preparation merge.
Changes:
- Pins the accepted target SHA and strengthens contracts.
- Records preflight, Environment, and post-merge safety gates.
- Preserves historical zero-target rejection behavior.
File summaries
| File | Description |
|---|---|
.github/workflows/workflow-delivery-v3-buddy-smoke-acceptance-retry-4.yml |
Pins the dispatch and guard target. |
governance.py |
Finalizes the retry-4 Governance profile. |
test_commit10_acceptance_retry_4_workflow.py |
Tests finalized workflow behavior. |
test_commit10_acceptance_evidence.py |
Tests admission and profile isolation. |
docs/wiki/overview.md |
Updates the current acceptance state. |
docs/wiki/log.md |
Records finalization activity. |
docs/wiki/analyses/workflow-delivery/v3/README.md |
Updates required next steps. |
docs/wiki/analyses/workflow-delivery/v3/hcoona-release-smoke-npm-lld.md |
Documents finalization safety gates. |
docs/wiki/analyses/workflow-delivery/v3/agent-handoff.md |
Updates the authoritative handoff. |
.testagent/status.md |
Records validation and review results. |
.testagent/research.md |
Records target and preflight research. |
.testagent/plan.md |
Records the protected-finalization plan. |
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
hcoona
deleted the
workflow-delivery-v3-acceptance-retry-4-finalization
branch
August 28, 2026 10:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
835b81be1ff0ba7aa0ec23c9a7b518d4ade3dfaaProtected state
Fresh authenticated preflight confirmed exact
main@835b81be, active ruleset and retry-4 workflow identity, green checks, no nonterminal or retry-4 workflow runs, no deployments or acceptance refs, and absent.13through.16package versions andwdv3-acceptance-13through-16npm tags.Environment
workflow-delivery-v3-buddy-smoke-acceptance-retry-4exists as ID20772100445with sole required reviewerhcoona(712433),prevent_self_review=false, and one custom deployment branch policy formain.Safety boundary
This PR does not dispatch the workflow, create an acceptance ref, approve a deployment, or mutate any package or tag. Zero and wrong dispatch inputs still fail before Environment review or either
packages: writeprobe. Normal Live andlive_enabled: trueremain unauthorized. No bypass is permitted.After this PR merges without bypass, a fresh exact preflight must pass before any acceptance ref is created or the single authorized
run_attempt == 1dispatch occurs. Any nonterminal or ambiguous state stops the operation for reconciliation.Validation
21 failed, 362 passed, all from the three expected zero target bindings383 passed806 passed3,837 passed3,837 passedCoordination
#595 and #605 still modify
.github/workflows/ci.ymlbut are not merged into this branch. #604 changes only .NET package versions and lock files. Their work is not duplicated here.