Prepare fourth Workflow Delivery v3 acceptance profile - #608
Merged
Conversation
Add the closed retry-4 package and Governance identities, a zero-target temporary workflow, and tests-first contracts for protected finalization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Normative Workflow Delivery v3 status pages remain at the pre-retry-4 checkpoint.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Prepares the fourth Workflow Delivery v3 destination-acceptance profile while keeping execution fail-closed.
Changes:
- Registers retry-4 Adapter and Governance bindings for coordinates
.13–.16. - Adds the guarded temporary workflow and comprehensive contracts.
- Updates preparation research, planning, and validation records.
File summaries
| File | Description |
|---|---|
.github/workflows/workflow-delivery-v3-buddy-smoke-acceptance-retry-4.yml |
Adds the fail-closed retry-4 workflow. |
.testagent/plan.md |
Records the tests-first plan. |
.testagent/research.md |
Documents retry-4 requirements and boundaries. |
.testagent/status.md |
Records implementation validation. |
src/public/lib/three-workflow-delivery-v3/src/three_workflow_delivery_v3/adapters/github_packages.py |
Registers Adapter coordinates .13–.16. |
src/public/lib/three-workflow-delivery-v3/src/three_workflow_delivery_v3/records/governance.py |
Registers the zero-target Governance profile. |
src/public/lib/three-workflow-delivery-v3/tests/adapters/test_commit10_acceptance_probes.py |
Tests Adapter isolation and routing. |
src/public/lib/three-workflow-delivery-v3/tests/contracts/test_buddy_workflows.py |
Allows only retry-4 during preparation. |
src/public/lib/three-workflow-delivery-v3/tests/contracts/test_commit10_acceptance_retry_4_workflow.py |
Defines the workflow’s static contracts. |
src/public/lib/three-workflow-delivery-v3/tests/contracts/test_commit11_legacy_buddy_retirement.py |
Preserves legacy retirement with one exception. |
src/public/lib/three-workflow-delivery-v3/tests/governance/test_commit10_acceptance_evidence.py |
Tests Governance bindings and historical replay. |
Review details
- Files reviewed: 11/11 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Synchronize the normative handoff and wiki with the zero-target preparation boundary and the protected finalization gates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
The rejected-dispatch terminal evidence path lacks an executable scenario test, leaving a central fail-closed guarantee unverified.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 1
- Review effort level: Balanced
Run the temporary workflow's terminal program for rejected dispatch inputs, isolate its subprocess environment, and preserve append-only validation records. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The large security-sensitive workflow and governance change warrants final human verification despite its extensive fail-closed tests.
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 0 new
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.13through.16Safety boundary
This is preparation only. The workflow cannot pass fixed-input validation while the target remains forty zeroes. It introduces no Live route, bypass, PAT/OIDC authority, generalized registry, Environment mutation, package mutation, workflow dispatch, or reuse of consumed
.1through.12identities.Terminal Governance evidence binds the fixed retry-4 confirmation identity even when dispatch validation rejects an input. Only the two probe jobs declare
packages: write, and neither can run before validation and protected Environment review succeed.Validation
Coordination
#595 and #605 independently modify
.github/workflows/ci.yml; neither is merged into this branch. Their current failures are not duplicated or repaired here.After this PR is reviewed and merged, the authorized next phase is to revalidate external state, create the fresh protected retry-4 Environment, revalidate external state as needed, and open a separate finalization PR that pins the reviewed target to this preparation merge SHA. The finalization PR must merge without bypass and a fresh exact preflight must pass before any acceptance ref is created or the single
run_attempt == 1attempt is dispatched.