feat: token freeze kyc and pause implemented - #256
Draft
arianejasuwienas wants to merge 1 commit into
Draft
Conversation
arianejasuwienas
marked this pull request as ready for review
March 3, 2025 15:56
2 tasks
arianejasuwienas
force-pushed
the
197-token-freeze-kyc-and-pause-without-checking-owner
branch
from
March 3, 2025 15:58
d3e685d to
6030e7b
Compare
arianejasuwienas
added
the
feature
arianejasuwienas
changed the title
arianejasuwienas
force-pushed
the
197-token-freeze-kyc-and-pause-without-checking-owner
branch
from
March 7, 2025 10:25
6030e7b to
61ca332
Compare
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
arianejasuwienas
force-pushed
the
197-token-freeze-kyc-and-pause-without-checking-owner
branch
from
March 7, 2025 15:23
61ca332 to
386d060
Compare
acuarica
reviewed
Mar 7, 2025
| } | ||
|
|
||
| function _checkToken(address token) private view returns (int64 tokenStatus) { | ||
| if (address(0) == token) return HederaResponseCodes.INVALID_TOKEN_ID; |
Contributor
There was a problem hiding this comment.
question: how did you validate that this is the correct behavior?
acuarica
marked this pull request as draft
March 7, 2025 21:31
Contributor
|
@arianejasuwienas marked this as draft because moving forward we should also include validation tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
implementing token freeze, kyc and pause functionalities. For now owner of the keys is not checked.
Related issue(s):
Fixes #197
Notes for reviewer:
Checklist