Skip to content

feat: token freeze, kyc and pause (#197) - #236

Closed
arianejasuwienas wants to merge 16 commits into
mainfrom
197-token-freeze-kyc-and-pause
Closed

feat: token freeze, kyc and pause (#197)#236
arianejasuwienas wants to merge 16 commits into
mainfrom
197-token-freeze-kyc-and-pause

Conversation

@arianejasuwienas

@arianejasuwienas arianejasuwienas commented Feb 10, 2025

Copy link
Copy Markdown
Contributor

Description:
Adds the support for token freeze, kyc and pause

CryptoTransfer and Key Support included (both functionalities are on different PullRequests, so this one should be merged last).

Related issue(s):

#197

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@arianejasuwienas arianejasuwienas self-assigned this Feb 10, 2025
@arianejasuwienas arianejasuwienas added the feature Enhancing an existing feature driven by business requirements. Typically backwards compatible. label Feb 10, 2025
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas
arianejasuwienas force-pushed the 197-token-freeze-kyc-and-pause branch from da1b0d9 to 3bb1932 Compare February 10, 2025 15:31
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas
arianejasuwienas marked this pull request as ready for review February 10, 2025 15:45
@arianejasuwienas
arianejasuwienas requested a review from a team as a code owner February 10, 2025 15:45
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas arianejasuwienas linked an issue Feb 12, 2025 that may be closed by this pull request
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
…197)

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@acuarica

Copy link
Copy Markdown
Contributor

Key support is already included, so let's give this priority. Let's make this PR only about Kyc/Freeze/pause, so it's easier to review.

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
@arianejasuwienas

Copy link
Copy Markdown
Contributor Author

@acuarica

The key check is implemented, but it only verifies the key's existence. To determine whether the call can be made, we need to extract the key owner.

If you prefer, we can create a separate issue for the validation. Let me know what works best for you.

@arianejasuwienas

Copy link
Copy Markdown
Contributor Author

@acuarica I'm closing this PR because it verifies the key owner, but the implementation includes a lot of code. Instead, I've created a new PR where the key owner is not verified (only key existence is checked) to simplify the review process (as you suggested): #256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Enhancing an existing feature driven by business requirements. Typically backwards compatible.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement token freeze, KYC, and pause functionalities

2 participants