Skip to content

Split Notifications Listeners into Mail/webhook ones - #19652

Open
uberbrady wants to merge 1 commit into
split_checkinout_notificationsfrom
split_notification_listeners
Open

uberbrady wants to merge 1 commit into
split_checkinout_notificationsfrom
split_notification_listeners

Split Notifications Listeners into Mail/webhook ones

9fe0414
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Sep 14, 2026 in 0s

8 new issues (0 max.) of at least severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
- Added 8
           

Complexity increasing per file
==============================
- app/Events/CheckoutableCheckedOut.php  1
- app/Listeners/CheckoutableCheckedInEmailNotification.php  19
- app/Listeners/CheckoutableCheckedInWebhookNotification.php  14
- app/Listeners/CheckoutableCheckedOutEmailNotification.php  21
- app/Listeners/CheckoutableCheckedOutWebhookNotification.php  15
         

See the complete overview on Codacy

Annotations

Check warning on line 28 in app/Listeners/CheckoutableCheckedInEmailNotification.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Listeners/CheckoutableCheckedInEmailNotification.php#L28

The class CheckoutableCheckedInEmailNotification has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.

Check warning on line 30 in app/Listeners/CheckoutableCheckedInEmailNotification.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Listeners/CheckoutableCheckedInEmailNotification.php#L30

The method handle() has an NPath complexity of 492. The configured NPath complexity threshold is 200.

Check warning on line 28 in app/Listeners/CheckoutableCheckedInWebhookNotification.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Listeners/CheckoutableCheckedInWebhookNotification.php#L28

The class CheckoutableCheckedInWebhookNotification has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.

Check notice on line 47 in app/Listeners/CheckoutableCheckedInWebhookNotification.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Listeners/CheckoutableCheckedInWebhookNotification.php#L47

The method handle uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.

Check warning on line 35 in app/Listeners/CheckoutableCheckedOutEmailNotification.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Listeners/CheckoutableCheckedOutEmailNotification.php#L35

The class CheckoutableCheckedOutEmailNotification has a coupling between objects value of 19. Consider to reduce the number of dependencies under 13.

Check warning on line 37 in app/Listeners/CheckoutableCheckedOutEmailNotification.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Listeners/CheckoutableCheckedOutEmailNotification.php#L37

The method handle() has an NPath complexity of 216. The configured NPath complexity threshold is 200.

Check warning on line 35 in app/Listeners/CheckoutableCheckedOutWebhookNotification.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Listeners/CheckoutableCheckedOutWebhookNotification.php#L35

The class CheckoutableCheckedOutWebhookNotification has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13.

Check notice on line 53 in app/Listeners/CheckoutableCheckedOutWebhookNotification.php

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

app/Listeners/CheckoutableCheckedOutWebhookNotification.php#L53

The method handle uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.