Skip to content

Split Notifications Listeners into Mail/webhook ones - #19652

Open
uberbrady wants to merge 1 commit into
split_checkinout_notificationsfrom
split_notification_listeners
Open

uberbrady wants to merge 1 commit into
split_checkinout_notificationsfrom
split_notification_listeners

Conversation

@uberbrady

@uberbrady uberbrady commented Sep 14, 2026

Copy link
Copy Markdown
Member

This further breaks out our various Listeners for Notifications - so that there's one listener that does Webhook stuff, and one that does Email stuff.

So, effectively, now we have four individual listeners, where we used to have just one:

  • CheckoutableCheckedInEmailNotification
  • CheckoutableCheckedInWebhookNotification
  • CheckoutableCheckedOutEmailNotification
  • CheckoutableCheckedOutWebhookNotification

This should make it easier to separately troubleshoot each and any of these separate notification events. There is a little bit of 'magic' around the $checkoutAcceptance property of the event itself, which is done to prevent us from inadvertently creating two checkout acceptances in the case where both the Webhook and the Email are both firing. But, in general, I feel like it's a lot clearer to reason about this way.

@uberbrady
uberbrady added this pull request to stack #19649 September 14, 2026 15:43
@uberbrady
uberbrady requested a review from snipe as a code owner September 14, 2026 15:43
@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 6 medium · 2 minor

Alerts:
⚠ 8 issues (≤ 0 issues of at least minor severity)

Results:
8 new issues

Category Results
CodeStyle 2 minor
Complexity 6 medium

View in Codacy

🟢 Metrics 69 complexity

Metric Results
Complexity 69

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@uberbrady
uberbrady force-pushed the split_notification_listeners branch from 014671d to 9fe0414 Compare September 14, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant