Conversation
uberbrady
added this pull request to stack #19649
September 14, 2026 15:43
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| CodeStyle | 2 minor |
| Complexity | 6 medium |
🟢 Metrics 69 complexity
Metric Results Complexity 69
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
uberbrady
force-pushed
the
split_notification_listeners
branch
from
September 14, 2026 16:06
014671d to
9fe0414
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This further breaks out our various Listeners for Notifications - so that there's one listener that does Webhook stuff, and one that does Email stuff.
So, effectively, now we have four individual listeners, where we used to have just one:
This should make it easier to separately troubleshoot each and any of these separate notification events. There is a little bit of 'magic' around the $checkoutAcceptance property of the event itself, which is done to prevent us from inadvertently creating two checkout acceptances in the case where both the Webhook and the Email are both firing. But, in general, I feel like it's a lot clearer to reason about this way.