Skip to content

fix(sequentialagent): correct New godoc placement and copy-pasted error string #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmora wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −4
Open

fix(sequentialagent): correct New godoc placement and copy-pasted error string #1151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions agent/workflowagents/sequentialagent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,8 @@ import (
"google.golang.org/adk/v2/tool/functiontool"
)

// New creates a SequentialAgent.
//
// SequentialAgent executes its sub-agents once, in the order they are listed.
// seqAgent is the agent returned by New; it augments the base agent with the
// live-mode entry point.
type seqAgent struct {
agent.Agent
*agentinternal.State
Expand All @@ -41,11 +40,14 @@ func (s *seqAgent) RunLive(ctx agent.InvocationContext) (agent.LiveSession, iter
return s.impl.RunLive(ctx)
}

// New creates a SequentialAgent.
//
// SequentialAgent executes its sub-agents once, in the order they are listed.
// Use the SequentialAgent when you want the execution to occur in a fixed,
// strict order.
func New(cfg Config) (agent.Agent, error) {
if cfg.AgentConfig.Run != nil {
return nil, fmt.Errorf("LoopAgent doesn't allow custom Run implementations")
return nil, fmt.Errorf("SequentialAgent doesn't allow custom Run implementations")
}

sequentialAgentImpl := &sequentialAgent{}
Expand Down
Loading