fix(sequentialagent): correct New godoc placement and copy-pasted error string#1151
Open
dmora wants to merge 1 commit into
Open
fix(sequentialagent): correct New godoc placement and copy-pasted error string#1151dmora wants to merge 1 commit into
dmora wants to merge 1 commit into
Conversation
…or string The "New creates a SequentialAgent" doc comment was attached to the seqAgent type after the live-mode changes inserted the type between the comment and func New, leaving New with only an orphaned fragment. Reunite the full doc comment with New and give seqAgent its own comment. Also fix the custom-Run guard error, which reported "LoopAgent" instead of "SequentialAgent" (copy-paste from loopagent; parallelagent names itself correctly).
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
// New creates a SequentialAgent.doc comment is attached to theseqAgenttype — the live-mode changes inserted the type declaration between the comment andfunc New, leavingNewwith only the orphaned "Use the SequentialAgent when..." fragment. This PR reunites the full doc comment withNewand givesseqAgentits own comment.It also fixes the custom-Run guard error string, which reports
LoopAgent doesn't allow custom Run implementationsfrom insidesequentialagent.New(copy-paste from loopagent — parallelagent names itself correctly).No behavior change beyond the error text.
go build ./agent/workflowagents/...,go vet, andgo test ./agent/workflowagents/...pass; no test asserts the old string.Found while integrating v1.5.0 into our fork.