Skip to content

Lock in generate_audio type-check precedence on always-on models #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christophervoelpel merged 1 commit into from
Sep 25, 2026
Merged

Lock in generate_audio type-check precedence on always-on models #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/test_submission_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1156,6 +1156,10 @@ def test_duration_non_int_rejected_when_resolution_omitted():
def test_non_bool_generate_audio_rejected(bad_audio):
params = {**_FULL_VALID_VIDEO, 'generate_audio': bad_audio}
assert _code(_sub('generate_video', params)) == 'MALFORMED_SUBMISSION'
# The type check runs before capability checks, so an audio-always-on model
# reports the malformed value rather than AUDIO_REQUIRED.
omni = {**_OMNI, 'generate_audio': bad_audio}
assert _code(_sub('generate_video', omni)) == 'MALFORMED_SUBMISSION'


@pytest.mark.parametrize('good_audio', (True, False))
Expand Down
Loading