Repository navigation
Lock in generate_audio type-check precedence on always-on models - #207
Merged
Merged
Conversation
Assert that a non-boolean generate_audio on an audio_always_on model (gemini-omni) is reported as MALFORMED_SUBMISSION, not AUDIO_REQUIRED. Without this, moving the type check back after the capability check passes the existing test unnoticed. Follow-up to review feedback from victor-paunescu on #204.
gps-readability-bot
Bot
requested review from
andersonfreitas and
evil-shrike
September 24, 2026 09:23
|
Still need readability approvals from:
|
|
Still need readability approvals from:
|
victor-paunescu
approved these changes
Sep 25, 2026
|
Still need readability approvals from:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #204. It applies @victor-paunescu's suggestion, which came with his approval of #204. I merged #204 on the approved head instead of pushing to it, so the approval stayed valid, and moved the suggestion here.
Change (test only):
test_non_bool_generate_audio_rejectednow also asserts that a non-booleangenerate_audiosent togemini-omni-1.1-flash-preview(a model that always generates audio) returnsMALFORMED_SUBMISSION, notAUDIO_REQUIRED. This locks in the check ordering that0d6a560introduced. I wrapped the suggested line to stay within 80 columns.Mutation check: I moved the type check back after
_capability_violation, i.e. the order before0d6a560.AUDIO_REQUIRED.