Skip to content

Refactor check_workgroup_sizes into a new struct WorkgroupSizeCheck#9733

Merged
andyleiserson merged 4 commits into
gfx-rs:trunkfrom
erichdongubler-mozilla:workgroup-size-check-struct
Jun 25, 2026
Merged

Refactor check_workgroup_sizes into a new struct WorkgroupSizeCheck#9733
andyleiserson merged 4 commits into
gfx-rs:trunkfrom
erichdongubler-mozilla:workgroup-size-check-struct

Conversation

@ErichDonGubler

Copy link
Copy Markdown
Member

Connections

Done while working on #9732.

Conflicts with #9732. I have a resolution ready in trunk...erichdongubler-mozilla:wgpu:erichdongubler-push-uovkovyvxuzq to handle this.

Description

I think this tidies this bit of code nicely. Recommended review experience is commit-by-commit.

Testing

Things still compile, so I think the risk of something breaking is low.

Squash or Rebase? rebaseplz

Checklist

  • I self-reviewed and fully understand this PR.
  • WebGPU implementations built with wgpu may be affected behaviorally.
  • Validation and feature gates are in place to confine behavioral changes.
  • Tests demonstrate the validation and altered logic works.
  • CHANGELOG.md entries for the user-facing effects of this change are present.
  • The PR is minimal, and doesn't make sense to land as multiple PRs.
  • Commits are logically scoped and individually reviewable.
  • The PR description has enough context to understand the motivation and solution implemented.

@ErichDonGubler ErichDonGubler added the kind: refactor Making existing function faster or nicer label Jun 24, 2026
@ErichDonGubler ErichDonGubler force-pushed the workgroup-size-check-struct branch from aea815c to 32a4710 Compare June 24, 2026 15:45
@andyleiserson andyleiserson merged commit 7e09573 into gfx-rs:trunk Jun 25, 2026
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: refactor Making existing function faster or nicer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants