Skip to content

Batch edit / update clipboard paste error message #9293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
josegar74 wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −4
Open

Batch edit / update clipboard paste error message #9293

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb924cc
Batch edit / update clipboard paste error message
josegar74 May 26, 2026
d680da6
Batch edit / add tooltip to the paste from clipboard button
josegar74 Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions web-ui/src/main/resources/catalog/js/edit/BatchEditController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,8 +498,7 @@
}
} catch (e) {
$rootScope.$broadcast("StatusUpdated", {
msg: $translate.instant("batchEditConfigIsNotJson"),
error: e,
msg: $translate.instant("batchEditConfigIsNotValid"),
timeout: 2,
type: "danger"
});
Expand Down
3 changes: 1 addition & 2 deletions web-ui/src/main/resources/catalog/locales/en-v4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,7 @@
"uuidMergePolicy": "UUID merge policy",
"filteringAndProcessing": "Filtering and processing response",
"recordCreationOptions": "Record creation options",
"batchEditConfigIsNotValid": "Batch edit configuration is invalid. It must be a JSON <pre>{\"insertMode\": \"gn_add\", \"xpath\": \"...\", \"value\": \"...\"}</pre>",
"batchEditConfigIsNotJson": "Batch edit configuration is not JSON.",
"batchEditConfigIsNotValid": "Batch edit configuration is invalid. Copy the configuration from another batch edit rule.",

@GeoSander GeoSander May 28, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@josegar74 Since this is about copying (not pasting) and the error happens when the configuration has bad input, I think it's best if the message says:

"Failed to copy invalid batch edit configuration. Please review and try again."

@josegar74 josegar74 May 29, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeoSander, it's about pasting.

The problem with this function is that it’s rather confusing. First, you have to copy another rule and paste it into the existing one. The problem arises when you paste it.

It could be implemented with just a Duplicate button, that doesn't require any clipboard interaction.

@GeoSander GeoSander Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @josegar74, I understood that shortly after my comment. Never used this feature but now that I saw it in action, I agree that the functionality is quite confusing.

The buttons could be clarified (more clear copy/paste icons), but what I think is cleaner is the following:

  • When you select an example in the dropdown, nothing happens yet.
  • Next to the Examples dropdown, there should be an "apply" button (or something with a clear icon for that purpose). This behaves in much the same way as the + button right now.
  • When you click that button, it fills in the expression in the existing form and not in a new form underneath the other one.
  • This would remove the need for copy/paste buttons and I think the UX/UI will be much more clear.

Does that make sense?

@josegar74 josegar74 Jun 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GeoSander

  • When you select an example in the dropdown, nothing happens yet.

When I select an example the form below is replaced with the example.

  • Next to the Examples dropdown, there should be an "apply" button (or something with a clear icon for that purpose). This behaves in much the same way as the + button right now.

The user most probably needs do changes in the fields like Condition or Text or XML value, or even the XPATH expression, before clicking the + button.

I'm not sure if the behaviour described by you would be the most appropiate.

  • When you click that button, it fills in the expression in the existing form and not in a new form underneath the other one.

I'm not following this.

  • This would remove the need for copy/paste buttons and I think the UX/UI will be much more clear.

I'm not following this either, as the copy & paste has nothing to do with the examples.

"testLink": "Test",
"metadata/link": "Link analysis",
"metadata/link/excludedUrlPattern": "Exclude URL from link analysis",
Expand Down
Loading