Batch edit / update clipboard paste error message#9293
Conversation
| "recordCreationOptions": "Record creation options", | ||
| "batchEditConfigIsNotValid": "Batch edit configuration is invalid. It must be a JSON <pre>{\"insertMode\": \"gn_add\", \"xpath\": \"...\", \"value\": \"...\"}</pre>", | ||
| "batchEditConfigIsNotJson": "Batch edit configuration is not JSON.", | ||
| "batchEditConfigIsNotValid": "Batch edit configuration is invalid. Copy the configuration from another batch edit rule.", |
There was a problem hiding this comment.
@josegar74 Since this is about copying (not pasting) and the error happens when the configuration has bad input, I think it's best if the message says:
"Failed to copy invalid batch edit configuration. Please review and try again."
There was a problem hiding this comment.
@GeoSander, it's about pasting.
The problem with this function is that it’s rather confusing. First, you have to copy another rule and paste it into the existing one. The problem arises when you paste it.
It could be implemented with just a Duplicate button, that doesn't require any clipboard interaction.
There was a problem hiding this comment.
Yes @josegar74, I understood that shortly after my comment. Never used this feature but now that I saw it in action, I agree that the functionality is quite confusing.
The buttons could be clarified (more clear copy/paste icons), but what I think is cleaner is the following:
- When you select an example in the dropdown, nothing happens yet.
- Next to the
Examplesdropdown, there should be an "apply" button (or something with a clear icon for that purpose). This behaves in much the same way as the+button right now. - When you click that button, it fills in the expression in the existing form and not in a new form underneath the other one.
- This would remove the need for copy/paste buttons and I think the UX/UI will be much more clear.
Does that make sense?
There was a problem hiding this comment.
- When you select an example in the dropdown, nothing happens yet.
When I select an example the form below is replaced with the example.
- Next to the Examples dropdown, there should be an "apply" button (or something with a clear icon for that purpose). This behaves in much the same way as the + button right now.
The user most probably needs do changes in the fields like Condition or Text or XML value, or even the XPATH expression, before clicking the + button.
I'm not sure if the behaviour described by you would be the most appropiate.
- When you click that button, it fills in the expression in the existing form and not in a new form underneath the other one.
I'm not following this.
- This would remove the need for copy/paste buttons and I think the UX/UI will be much more clear.
I'm not following this either, as the copy & paste has nothing to do with the examples.
3 participants
When batch edit paste clipboard fails due to unexpected format (expects a JSON with the copied value of another batch edit rule), displays a cryptic error, including even the exception message.
The user doesn't really cares about JSON or whatever format is used internally by the application. Updated to avoid displaying the exception and showing a more friendly message.
Checklist
mainbranch, backports managed with labelREADME.mdfilespom.xmldependency management. Update build documentation with intended library use and library tutorials or documentation