Skip to content

validate_package_xml: check with xmllint #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scpeters merged 2 commits into from
Sep 2, 2025
Merged

validate_package_xml: check with xmllint #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca4011a
validate_package_xml: check with xmllint
scpeters Sep 2, 2025
41a3184
fast check first: versions before syntax
scpeters Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 15 additions & 12 deletions validate_package_xml/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,6 @@ runs:
- name: Checkout
uses: actions/checkout@v4

# TODO(azeey) Uncomment once https://github.com/ros-infrastructure/rep/pull/400
# is merged and the .xsd changes have propagated to ament_xmllint.
# - name: package.xml syntax validation
# shell: bash
# run: |
# echo "Install ament-xmllint"
# sudo apt-get install -y python3-venv libxml2-utils
# python3 -m venv .venv
# source .venv/bin/activate
# pip install ament-xmllint
# ament_xmllint package.xml 2>&1 | tee $GITHUB_STEP_SUMMARY

- name: package.xml and CMake versions match
shell: bash
run: |
Expand All @@ -28,3 +16,18 @@ runs:
cmake_version=$(sed -nE 's/^project.*VERSION\s*([0-9.]*).*/\1/p' CMakeLists.txt)
echo "Version in CMake: ${cmake_version}" | tee -a $GITHUB_STEP_SUMMARY
[ $package_xml_version = $cmake_version ]

- name: package.xml syntax validation
shell: bash
run: |
echo "Install xmllint"
sudo apt-get install -y libxml2-utils
xmllint --noout package.xml
# TODO(azeey) Uncomment once https://github.com/ros-infrastructure/rep/pull/400
# is merged and the .xsd changes have propagated to ament_xmllint.
# echo "Install ament-xmllint"
# sudo apt-get install -y python3-venv
# python3 -m venv .venv
# source .venv/bin/activate
# pip install ament-xmllint
# ament_xmllint package.xml 2>&1 | tee $GITHUB_STEP_SUMMARY