validate_package_xml: check with xmllint - #85
Merged
Conversation
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to gazebosim/gz-jetty
that referenced
this pull request
Sep 2, 2025
Testing gazebo-tooling/action-gz-ci#85 Signed-off-by: Steve Peters <computersthatmove@gmail.com>
scpeters
added a commit
to gazebosim/gz-jetty
that referenced
this pull request
Sep 2, 2025
Testing gazebo-tooling/action-gz-ci#85 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
marked this pull request as ready for review
September 2, 2025 17:56
azeey
approved these changes
Sep 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #84.
Summary
There is a commented bit of code to use
ament_xmllintthat is waiting on ros-infrastructure/rep#400 to be merged. In the meantime, just usexmllint --nooutto check for XML syntax errors (see ca4011a).Since installing
libxml2-utilscan be slow, move the XML syntax after the version check (see 41a3184).Testing
Tested in gazebosim/gz-jetty#118: