Skip to content

fix(a11y): add alt text to images missing it #3698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
swe-sanad wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(a11y): add alt text to images missing it #3698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion desk/src/components/AttachmentItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
>
{{ content }}
</div>
<img v-if="isImage" :src="url" class="m-auto rounded border" />
<img v-if="isImage" :src="url" :alt="label" class="m-auto rounded border" />
<video
v-if="isVideo"
:src="url"
Expand Down
2 changes: 1 addition & 1 deletion desk/src/components/Settings/EmailProviderIcon.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
class="flex size-8 cursor-pointer items-center justify-center rounded-full bg-surface-gray-2 hover:bg-surface-gray-3"
:class="{ 'ring-2 ring-outline-blue-4': selected }"
>
<img v-if="logoValue" :src="logoValue" class="size-4.5" />
<img v-if="logoValue" :src="logoValue" :alt="serviceName || 'Email provider'" class="size-4.5" />

@greptile-apps greptile-apps Bot Aug 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Provider name announced twice

When serviceName is supplied, the image alt repeats the adjacent provider name, causing screen readers to announce the same text twice. Mark the redundant logo as decorative.

Suggested change
<img v-if="logoValue" :src="logoValue" :alt="serviceName || 'Email provider'" class="size-4.5" />
<img v-if="logoValue" :src="logoValue" alt="" class="size-4.5" />

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Codex

<LucideMail v-else class="size-4.5 text-ink-gray-7" />
</div>
<p v-if="serviceName" class="text-center text-p-xs text-ink-gray-7">
Expand Down
1 change: 1 addition & 0 deletions desk/src/components/Settings/Preferences/components/ThemeSwitcher.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@
<img
v-if="logoIsImage"
:src="logo as string"
alt=""
class="size-5 object-cover"
/>
<component
Expand Down
2 changes: 1 addition & 1 deletion desk/src/composables/useApps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export function useApps() {
icon: markRaw(AppsIcon),
submenu: apps.value.map((app) => ({
label: app.title,
icon: h("img", { src: app.logo }),
icon: h("img", { src: app.logo, alt: "" }),
onClick: () => window.open(app.route, "_self"),
})),
}));
Expand Down