Skip to content

fix(a11y): add alt text to images missing it - #3698

Open
swe-sanad wants to merge 1 commit into
frappe:developfrom
SWE-Pioneers:fix/a11y-alt-text
Open

fix(a11y): add alt text to images missing it#3698
swe-sanad wants to merge 1 commit into
frappe:developfrom
SWE-Pioneers:fix/a11y-alt-text

Conversation

@swe-sanad

Copy link
Copy Markdown

Problem

Several images across the desk frontend had no alt attribute.

Fix

Same pattern as the sibling fix already sent to frappe/crm: icon-next-to-visible-label images (app menu, theme preview) get alt=""; a standalone image with no adjacent label (the attachment preview) gets a real description from the filename already in scope.

Apps.vue no longer exists on develop — its app-menu icon moved into useApps.ts's appMenuItems(), fixed there instead. AttachmentItem.vue also gained video-attachment support since I last looked — kept that as-is and added the alt fix alongside it.

Same pattern as the sibling frappe/crm fix: icon-next-to-visible-label
images (app menu, theme preview) get alt=""; standalone images with no
adjacent label (attachment preview) get a real description from the
filename already in scope.

Apps.vue no longer exists on develop — its app-menu icon moved into
useApps.ts's appMenuItems(), fixed there instead. AttachmentItem.vue also
gained video-attachment support upstream since this fork last synced;
kept that and added the alt fix alongside it.
@mergify

mergify Bot commented Aug 14, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@greptile-apps

greptile-apps Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

The PR appears safe to merge after the non-blocking duplicate provider announcement is addressed.

Provider logos repeat the same accessible text rendered immediately beside them, while the other alt additions preserve useful labeling.

Files Needing Attention: desk/src/components/Settings/EmailProviderIcon.vue

Fix all with Greploop

Fix All in Claude Code Fix All in Codex

Reviews (1): Last reviewed commit: "fix(a11y): add alt text to images missin..." | Re-trigger Greptile

:class="{ 'ring-2 ring-outline-blue-4': selected }"
>
<img v-if="logoValue" :src="logoValue" class="size-4.5" />
<img v-if="logoValue" :src="logoValue" :alt="serviceName || 'Email provider'" class="size-4.5" />

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Provider name announced twice

When serviceName is supplied, the image alt repeats the adjacent provider name, causing screen readers to announce the same text twice. Mark the redundant logo as decorative.

Suggested change
<img v-if="logoValue" :src="logoValue" :alt="serviceName || 'Email provider'" class="size-4.5" />
<img v-if="logoValue" :src="logoValue" alt="" class="size-4.5" />

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code Fix in Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants