fix(a11y): add alt text to images missing it - #3698
Conversation
Same pattern as the sibling frappe/crm fix: icon-next-to-visible-label images (app menu, theme preview) get alt=""; standalone images with no adjacent label (attachment preview) get a real description from the filename already in scope. Apps.vue no longer exists on develop — its app-menu icon moved into useApps.ts's appMenuItems(), fixed there instead. AttachmentItem.vue also gained video-attachment support upstream since this fork last synced; kept that and added the alt fix alongside it.
|
Tick the box to add this pull request to the merge queue (same as
|
Confidence Score: 4/5The PR appears safe to merge after the non-blocking duplicate provider announcement is addressed. Provider logos repeat the same accessible text rendered immediately beside them, while the other alt additions preserve useful labeling. Files Needing Attention: desk/src/components/Settings/EmailProviderIcon.vue Reviews (1): Last reviewed commit: "fix(a11y): add alt text to images missin..." | Re-trigger Greptile |
| :class="{ 'ring-2 ring-outline-blue-4': selected }" | ||
| > | ||
| <img v-if="logoValue" :src="logoValue" class="size-4.5" /> | ||
| <img v-if="logoValue" :src="logoValue" :alt="serviceName || 'Email provider'" class="size-4.5" /> |
There was a problem hiding this comment.
When serviceName is supplied, the image alt repeats the adjacent provider name, causing screen readers to announce the same text twice. Mark the redundant logo as decorative.
| <img v-if="logoValue" :src="logoValue" :alt="serviceName || 'Email provider'" class="size-4.5" /> | |
| <img v-if="logoValue" :src="logoValue" alt="" class="size-4.5" /> |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Problem
Several images across the desk frontend had no
altattribute.Fix
Same pattern as the sibling fix already sent to frappe/crm: icon-next-to-visible-label images (app menu, theme preview) get
alt=""; a standalone image with no adjacent label (the attachment preview) gets a real description from the filename already in scope.Apps.vueno longer exists ondevelop— its app-menu icon moved intouseApps.ts'sappMenuItems(), fixed there instead.AttachmentItem.vuealso gained video-attachment support since I last looked — kept that as-is and added the alt fix alongside it.