Skip to content

fix: render ticket timeline legend from what the rail draws #3697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RitvikSardana wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: render ticket timeline legend from what the rail draws #3697

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 23 additions & 8 deletions desk/src/components/ticket-agent/analytics/TicketTimeline.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@
class="flex flex-wrap gap-x-4 gap-y-1 px-4 pb-4 text-xs text-ink-gray-5"
>
<span
v-for="item in LEGEND"
v-for="item in legend"
:key="item.label"
class="flex items-center gap-1.5"
>
Expand Down Expand Up @@ -150,13 +150,6 @@ const OVERDUE =
const TODAY =
"bg-[var(--surface-base)] border-[1.5px] border-[var(--outline-gray-4)]";

const LEGEND = [
{ colorClass: GREEN, label: __("SLA met") },
{ colorClass: RED, label: __("SLA missed / longest wait") },
{ colorClass: CUSTOMER, label: __("Customer message") },
{ colorClass: BLUE, label: __("Agent reply") },
];

const props = defineProps<{
timeline: TimelineNode[];
events: TimelineEvent[];
Expand Down Expand Up @@ -264,6 +257,28 @@ const segments = computed<RailSegment[]>(() => {
return result;
});

// only the colors actually drawn on the rail get a legend entry
const legend = computed(() => {
const labels: Record<string, string> = {
[GREEN]: __("SLA met"),
[RED]: redLabel.value,
[CUSTOMER]: __("Customer message"),
[BLUE]: __("Agent reply"),
[PENDING]: __("Pending"),
};
const drawn = new Set(segments.value.map((segment) => segment.colorClass));
return Object.entries(labels)
.filter(([colorClass]) => drawn.has(colorClass))
.map(([colorClass, label]) => ({ colorClass, label }));
});

// red marks a breach and the longest wait, so it is named after whichever is on the rail
const redLabel = computed(() => {
const isMissed = props.timeline.some((node) => node.state === "breach");
if (isMissed && longestWait.value) return __("SLA missed / longest wait");
return isMissed ? __("SLA missed") : __("Longest wait");
});

function getFirstResponseSegments(node: TimelineNode): RailSegment[] {
if (node.state === "breach" && !node.timestamp && node.eta)
return getOverdueStartSegments(node);
Expand Down
Loading