Skip to content

fix: render ticket timeline legend from what the rail draws - #3697

Open
RitvikSardana wants to merge 1 commit into
frappe:developfrom
RitvikSardana:fix/dynamic-timeline-legend
Open

fix: render ticket timeline legend from what the rail draws#3697
RitvikSardana wants to merge 1 commit into
frappe:developfrom
RitvikSardana:fix/dynamic-timeline-legend

Conversation

@RitvikSardana

Copy link
Copy Markdown
Member

Timeline legend was static, so it listed colors the rail never drew. Now it renders only what is on the rail, adds the black Pending dot, and names red for its actual cause (SLA missed, Longest wait, or both).

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.76%. Comparing base (c3ae467) to head (fe2ebae).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3697   +/-   ##
========================================
  Coverage    73.76%   73.76%           
========================================
  Files          148      148           
  Lines        10841    10841           
========================================
  Hits          7997     7997           
  Misses        2844     2844           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RitvikSardana RitvikSardana changed the title fix: render timeline legend from what the rail draws fix: render ticket timeline legend from what the rail draws Aug 15, 2026
@RitvikSardana
RitvikSardana marked this pull request as ready for review August 15, 2026 15:46
@mergify

mergify Bot commented Aug 15, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@greptile-apps

greptile-apps Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

The computed legend remains reactive and consistently represents every labeled color rendered by the timeline rail.

Reviews (1): Last reviewed commit: "fix: render timeline legend from what th..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants