Skip to content

Respect explicit privacy restrictions even when HIDE_LIVE_PEOPLE is disabled #5426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnilebein wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −5
Open

Respect explicit privacy restrictions even when HIDE_LIVE_PEOPLE is disabled #5426

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e62fe9b
Respect explicit privacy restrictions even when HIDE_LIVE_PEOPLE is d…
Jul 21, 2026
7cbc258
chore: retrigger scrutinizer build
Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions app/GedcomRecord.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -949,11 +949,6 @@ private function parseFacts(): array
*/
private function canShowRecord(int $access_level): bool
{
// This setting would better be called "$ENABLE_PRIVACY"
if (!$this->tree->getPreference('HIDE_LIVE_PEOPLE')) {
return true;
}

// We should always be able to see our own record (unless an admin is applying download restrictions)
if ($this->xref() === $this->tree->getUserPreference(Auth::user(), UserInterface::PREF_TREE_ACCOUNT_XREF) && $access_level === Auth::accessLevel($this->tree)) {
return true;
Expand Down Expand Up @@ -987,6 +982,13 @@ private function canShowRecord(int $access_level): bool
return true;
}

// This setting would better be called "$ENABLE_PRIVACY".
// It only controls the *default* rules for living people (see canShowByType()) -
// explicit restrictions (RESN tags, individual privacy overrides, above) always apply.
if (!$this->tree->getPreference('HIDE_LIVE_PEOPLE')) {
return true;
}

// Different types of record have different privacy rules
return $this->canShowByType($access_level);
}
Expand Down