Respect explicit privacy restrictions even when HIDE_LIVE_PEOPLE is disabled - #5426
Open
gnilebein wants to merge 2 commits into
Open
Respect explicit privacy restrictions even when HIDE_LIVE_PEOPLE is disabled#5426gnilebein wants to merge 2 commits into
gnilebein wants to merge 2 commits into
Conversation
added 2 commits
July 21, 2026 14:10
…isabled Previously, disabling the tree's "hide living people" setting caused canShowRecord() to return true immediately, bypassing RESN restriction notices and individual-level privacy overrides for every record. Move that check after the explicit restriction checks so an individual marked private is still hidden, even when living people are otherwise shown to visitors.
Owner
|
Hi @gnilebein This is an interesting change! We are approaching a major version release, so this is a good time to make such a change. We would need to update the GUI to make this option clear. Once that is done, I would want to discuss/explain the change on the project forum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, disabling the tree's "hide living people" setting caused canShowRecord() to return true immediately, bypassing RESN restriction notices and individual-level privacy overrides for every record. Move that check after the explicit restriction checks so an individual marked private is still hidden, even when living people are otherwise shown to visitors.