Combine snake oils - #13980
Conversation
|
Screenshots differ from baselines. A baseline update PR has been prepared: equinor/ert-testdata#46 |
b1d688b to
4640d75
Compare
4640d75 to
d50b84e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13980 +/- ##
==========================================
- Coverage 91.40% 91.39% -0.02%
==========================================
Files 481 481
Lines 34213 34213
==========================================
- Hits 31273 31268 -5
- Misses 2940 2945 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
ac0238e to
f7a4f14
Compare
| REPORT_STEPS:199 | ||
|
|
||
| GEN_KW SNAKE_OIL_PARAM_BPR templates/snake_oil_template.txt snake_oil_params.txt parameters/snake_oil_parameters_BPR.txt | ||
| GEN_KW SNAKE_OIL_PARAM_OP1 templates/snake_oil_template.txt snake_oil_params.txt parameters/snake_oil_parameters_OP1.txt |
There was a problem hiding this comment.
Out of curiosity, why we need to have a separate OP1 and OP2 groups?
There was a problem hiding this comment.
It the way its done in snake_oil_field.py
xjules
left a comment
There was a problem hiding this comment.
I think it is good!
Please provide a commit message explaining (on a higher level) the changes.
| GEN_KW SNAKE_OIL_PARAM_BPR templates/snake_oil_template.txt snake_oil_params.txt parameters/snake_oil_parameters_BPR.txt | ||
| GEN_KW SNAKE_OIL_PARAM_OP1 templates/snake_oil_template.txt snake_oil_params.txt parameters/snake_oil_parameters_OP1.txt | ||
| GEN_KW SNAKE_OIL_PARAM_OP2 templates/snake_oil_template.txt snake_oil_params.txt parameters/snake_oil_parameters_OP2.txt |
There was a problem hiding this comment.
This seems to be what triggered equinor/ert-testdata#46, attempt at more info in:
#14017 (comment)
Issue
Resolves #12784
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable