Skip to content

Fixup error from ed77de3 - #14107

Merged
berland merged 1 commit into
equinor:mainfrom
berland:fix_test_screenshot_bug
Aug 5, 2026
Merged

Fixup error from ed77de3#14107
berland merged 1 commit into
equinor:mainfrom
berland:fix_test_screenshot_bug

Conversation

@berland

@berland berland commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Test failure went un-noticed in #13980 because of bug in workflow file

Issue
Resolves missing screenshot update.

Approach
🧠

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When screenshots are changed: Review screenshot-PR in ert-testdata,
    merge screenshot-PR in ert-testdata before merging this PR.
  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

Test failure went un-noticed because of bug in workflow file
@berland berland self-assigned this Aug 5, 2026
@berland berland added this to SCOUT Aug 5, 2026
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Aug 5, 2026
@ertomatic

Copy link
Copy Markdown
Collaborator

Screenshots differ from baselines. A baseline update PR has been prepared: equinor/ert-testdata#76

@codecov-commenter

codecov-commenter commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (9b4a00f) to head (9127943).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #14107    +/-   ##
========================================
  Coverage   91.87%   91.87%            
========================================
  Files         484      479     -5     
  Lines       33581    33397   -184     
========================================
- Hits        30851    30685   -166     
+ Misses       2730     2712    -18     
Flag Coverage Δ
cli-tests 36.30% <ø> (+0.13%) ⬆️
fuzz 44.27% <ø> (+0.18%) ⬆️
gui-tests 58.64% <ø> (+0.24%) ⬆️
performance-and-unit-tests 80.72% <ø> (+0.24%) ⬆️
test 46.07% <ø> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 20 files with indirect coverage changes

@berland berland moved this to Fast Track in SCOUT Aug 5, 2026

@ajaust ajaust left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩹

@github-project-automation github-project-automation Bot moved this from Fast Track to Reviewed in SCOUT Aug 5, 2026
berland pushed a commit to equinor/ert-testdata that referenced this pull request Aug 5, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@berland
berland merged commit 864db9e into equinor:main Aug 5, 2026
99 of 101 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewed to Done in SCOUT Aug 5, 2026
@codspeed-hq

codspeed-hq Bot commented Aug 5, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing berland:fix_test_screenshot_bug (9127943) with main (6a3a8b7)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:skip If there should be no mention of this in release notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants