Skip to content

Add Java 11 to the Gradle workflow matrix #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmdietl merged 1 commit into from
Mar 7, 2026
Merged

Add Java 11 to the Gradle workflow matrix #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gradle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

strategy:
matrix:
java: ['17', '21', '25']
java: ['11', '17', '21', '25']

Copilot AI Mar 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow matrix now includes Java 11, but the build/tests still won’t actually run on the matrix JDK because the job forces Gradle to use JDK 21 via org.gradle.java.home=$JAVA_HOME_21_X64 (so ./gradlew build, test, etc. run on 21 for every matrix entry). If the goal is to validate Java 11 compatibility, consider either (a) configuring Gradle toolchains / Test.javaLauncher to run tests on ${{ matrix.java }} while keeping the Gradle daemon on 21, or (b) adding an explicit runtime smoke test (run the built artifact with java from the matrix JDK) so each matrix entry provides real coverage.

Copilot uses AI. Check for mistakes.

@wmdietl wmdietl Mar 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Create a separate PR that does (a)


steps:
- uses: actions/checkout@v6
Expand Down