Skip to content

Add Java 11 to the Gradle workflow matrix#154

Merged
wmdietl merged 1 commit into
masterfrom
jdk11
Mar 7, 2026
Merged

Add Java 11 to the Gradle workflow matrix#154
wmdietl merged 1 commit into
masterfrom
jdk11

Conversation

@wmdietl

@wmdietl wmdietl commented Mar 7, 2026

Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 7, 2026 22:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions Gradle CI workflow to include Java 11 in the test matrix, aligning CI with the project’s declared Java 11 source/target compatibility.

Changes:

  • Add Java 11 to the Gradle workflow matrix.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

strategy:
matrix:
java: ['17', '21', '25']
java: ['11', '17', '21', '25']

Copilot AI Mar 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow matrix now includes Java 11, but the build/tests still won’t actually run on the matrix JDK because the job forces Gradle to use JDK 21 via org.gradle.java.home=$JAVA_HOME_21_X64 (so ./gradlew build, test, etc. run on 21 for every matrix entry). If the goal is to validate Java 11 compatibility, consider either (a) configuring Gradle toolchains / Test.javaLauncher to run tests on ${{ matrix.java }} while keeping the Gradle daemon on 21, or (b) adding an explicit runtime smoke test (run the built artifact with java from the matrix JDK) so each matrix entry provides real coverage.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Create a separate PR that does (a)

Copilot AI commented Mar 7, 2026

Copy link
Copy Markdown

@wmdietl I've opened a new pull request, #155, to work on those changes. Once the pull request is ready, I'll request review from you.

@wmdietl wmdietl merged commit 48867b0 into master Mar 7, 2026
14 checks passed
@wmdietl wmdietl deleted the jdk11 branch March 7, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants