Skip to content

JEventProcessorPODIO: remove EcalBarrelScFi*Pulses* from the default output - #2836

Merged
wdconinc merged 1 commit into
mainfrom
pr/no_bic_pulse
Aug 11, 2026
Merged

JEventProcessorPODIO: remove EcalBarrelScFi*Pulses* from the default output#2836
wdconinc merged 1 commit into
mainfrom
pr/no_bic_pulse

Conversation

@veprbl

@veprbl veprbl commented Aug 6, 2026

Copy link
Copy Markdown
Member

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

We enable most collections by default to exercise the underlying algorithms, and happy to provide those that are used by the analyzers. Unfortunately, these are quite large and not as useful. With #2732 and #2770 and other next changes coming up to provide the full functionality, we will soon have necessary components reengaged anyway, or so I hope.

image

What is the urgency of this PR?

  • High (please describe reason below)
  • Medium
  • Low

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Optimization (issue #__)
  • Updated parameters, constants (issue #__)
  • Updated documentation
  • other: __

Please check if any of the following apply

  • This PR requires changes to geometry (epic PR: __)
  • This PR requires changes to EDM4eic (EDM PR: __)
  • This PR introduces breaking changes. Please describe changes users need to make below.
  • This PR changes default behavior. Please describe changes below.
  • AI was used in preparing this PR. Please describe usage below.

Copilot AI lite review requested due to automatic review settings August 6, 2026 16:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Comment thread src/services/io/podio/JEventProcessorPODIO.cc
Copilot AI review requested due to automatic review settings August 10, 2026 14:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@veprbl
veprbl requested review from mhkim-anl and ssedd1123 August 10, 2026 23:52
Copilot AI review requested due to automatic review settings August 11, 2026 02:51
@wdconinc
wdconinc enabled auto-merge August 11, 2026 02:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 11, 2026 13:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@wdconinc
wdconinc added this pull request to the merge queue Aug 11, 2026
Merged via the queue into main with commit ef20cce Aug 11, 2026
161 of 163 checks passed
@wdconinc
wdconinc deleted the pr/no_bic_pulse branch August 11, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants