fix: Remove redundant EDM4eic version guards for minimum 8.7

[Copilot]

Removes version guard checks for EDM4eic >= 8.7 across the codebase. The minimum required version is already set to 8.7 in CMakeLists.txt, making these guards always true and unnecessary.

Changes

• src/algorithms/digi/CALOROCDigitization.cc - Removed guard wrapping entire implementation
• src/algorithms/tracking/TrackSeeding.cc - Removed guard around setQuality() call
• src/detectors/BEMC/BEMC.cc - Removed 2 guards (include and factory registration)
• src/services/io/podio/JEventProcessorPODIO.cc - Removed guard around CALOROC collection names
• src/tests/algorithms_test/digi_CALOROCDigitization.cc - Removed guard wrapping test

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

Eliminates technical debt by removing always-true preprocessor guards, improving code clarity and maintainability.

What is the urgency of this PR?

• High (please describe reason below)
• Medium
• Low

What kind of change does this PR introduce?

• Bug fix (issue #__)
• New feature (issue #__)
• Optimization (issue #__)
• Updated parameters, constants (issue #__)
• Updated documentation
• other: __

Please check if any of the following apply

• This PR requires changes to geometry (epic PR: __)
• This PR requires changes to EDM4eic (EDM PR: __)
• This PR introduces breaking changes. Please describe changes users need to make below.
• This PR changes default behavior. Please describe changes below.
• AI was used in preparing this PR. Please describe usage below.

• Fixes Didn't we bump the minimum EDM4eic to 8.7 already? What's this guard doing here? #2837

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

[github-actions]

Capybara summary for PR 2838

• rec_dis_10x100_minQ2=0_craterlake_10x100_MT (Δ: 359)
• rec_dis_10x100_minQ2=100_craterlake_tracking_2DStrip (Δ: 0)
• rec_dis_10x100_minQ2=100_craterlake_tracking_only (Δ: 0)
• rec_dis_10x130_minQ2=1_craterlake_10x130 (Δ: 0)
• rec_dis_10x250_minQ2=1_craterlake_10x250 (Δ: 0)
• rec_dis_18x275_minQ2=0_craterlake_18x275 (Δ: 0)
• rec_dis_18x275_minQ2=0_craterlake_18x275_MT (Δ: 343)
• rec_dis_18x275_minQ2=0_craterlake_18x275_ST_MT (Δ: 343)
• rec_dis_18x275_minQ2=100_craterlake_18x275 (Δ: 0)
• rec_dis_18x275_minQ2=100_craterlake_18x275_MT (Δ: 487)
• rec_dis_18x275_minQ2=100_craterlake_18x275_ST_MT (Δ: 391)
• rec_dis_5x41_minQ2=0_craterlake_5x41 (Δ: 0)
• rec_e_1GeV_20GeV_craterlake (Δ: 0)
• rec_pi_1GeV_20GeV_craterlake (Δ: 3)
• two_stage_raw_e_1GeV_20GeV_craterlake (Δ: 0)
• two_stage_rec_e_1GeV_20GeV_craterlake (Δ: 0)

Last updated 2026-08-11T21:53-04:00 0ddb719

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/tests/algorithms_test/digi_CALOROCDigitization.cc:6

• This file still uses unqualified fixed-width types (e.g. uint16_t) later on. <cstdint> only guarantees these typedefs in std::, while the global aliases are not guaranteed, which can hurt portability. Easiest fix is to keep the previous C header include (<stdint.h>), or alternatively switch the later usage to std::uint16_t.

#include <cstdint>

[wdconinc]

Conflict resolved; needs new approval.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/tests/algorithms_test/digi_CALOROCDigitization.cc:9

• <cstdint> only guarantees fixed-width integer typedefs in the std:: namespace. This file still uses uint16_t unqualified later, which can be a compile error on implementations that don’t also provide these typedefs in the global namespace. Prefer std::uint16_t, or add a using declaration after the includes.

#include <cstdint>
#include <cstddef>
#include <memory>

[ruse-traveler]

Thanks for the fix, @wdconinc! Looks good to me!

I am noticing some odd diffs in the capybara report (e.g. in the DRICH theta-phi photons and the BIC N combined pulses, attached here). But given the changes (and that all of them seem to be in multithreading comparisons), I suspect these are unrelated...

[wdconinc]

Thanks for the fix, @wdconinc! Looks good to me!

I am noticing some odd diffs in the capybara report (e.g. in the DRICH theta-phi photons and the BIC N combined pulses, attached here). But given the changes (and that all of them seem to be in multithreading comparisons), I suspect these are unrelated...

_DRICHGasIrtCherenkovParticleID_thetaPhiPhotons.b has always been irreproducible. It's a problem in (at this point) IRT1, so the priority on fixing it is low (I already spent a few hours on it and found no immediate reasons). I suspect it's going to be a problem in IRT2 as well, but we have not been able to assess that. IRT1 (and IRT2, tbh) are not written with multi-threaded reproducibility in mind.

EcalBarrelScFiNCombinedPulses were just removed in ef20cce, so that's a TOCTOU issue.

[ruse-traveler]

_DRICHGasIrtCherenkovParticleID_thetaPhiPhotons.b has always been irreproducible. It's a problem in (at this point) IRT1, so the priority on fixing it is low (I already spent a few hours on it and found no immediate reasons). I suspect it's going to be a problem in IRT2 as well, but we have not been able to assess that. IRT1 (and IRT2, tbh) are not written with multi-threaded reproducibility in mind.

EcalBarrelScFiNCombinedPulses were just removed in ef20cce, so that's a TOCTOU issue

Ahhhh I see!