Add CalorimeterCALOROCCalibration - #2770
Open
ssedd1123 wants to merge 107 commits into
Open
Conversation
for more information, see https://pre-commit.ci
…#2733) This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/28724507484. Please merge this PR into the branch `2728-edep-to-npe-conversion` to resolve failures in PR #2732. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
…#2734) This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/28753860813. Please merge this PR into the branch `2728-edep-to-npe-conversion` to resolve failures in PR #2732. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
github-actions
Bot
added
topic: calorimetry
Co-authored-by: Derek M Anderson <derek.murphy.anderson@protonmail.com>
Co-authored-by: Derek M Anderson <derek.murphy.anderson@protonmail.com>
… to config object.
This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/30936752913. Please merge this PR into the branch `pr/ECAL_calibration` to resolve failures in PR #2770. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
14 tasks
…ns are no longer needed and are rmoved
for more information, see https://pre-commit.ci
…#2847) This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/31276865409. Please merge this PR into the branch `2728-edep-to-npe-conversion` to resolve failures in PR #2732. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
AkshayaVijay
pushed a commit
to AkshayaVijay/EICrecon
that referenced
this pull request
Aug 11, 2026
…output (eic#2836) ### Briefly, what does this PR introduce? Please link to any relevant presentations or discussions. We enable most collections by default to exercise the underlying algorithms, and happy to provide those that are used by the analyzers. Unfortunately, these are quite large and not as useful. With eic#2732 and eic#2770 and other next changes coming up to provide the full functionality, we will soon have necessary components reengaged anyway, or so I hope. <img width="1920" height="870" alt="image" src="https://github.com/user-attachments/assets/b7bf26ab-d9b7-4bec-aeff-5fbbfb0ba128" /> ### What is the urgency of this PR? - [x] High (please describe reason below) - [ ] Medium - [ ] Low ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Optimization (issue #__) - [ ] Updated parameters, constants (issue #__) - [ ] Updated documentation - [ ] other: __ ### Please check if any of the following apply - [ ] This PR requires changes to geometry (epic PR: __) - [ ] This PR requires changes to EDM4eic (EDM PR: __) - [ ] This PR introduces breaking changes. Please describe changes users need to make below. - [ ] This PR changes default behavior. Please describe changes below. - [ ] AI was used in preparing this PR. Please describe usage below.
debug info is updated to print layer_idx on line 97
veprbl
reviewed
Aug 13, 2026
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
for more information, see https://pre-commit.ci
…compile with temporary path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.
Added CalorimeterCALOROCCalibration class to convert the CALOROC ADC/TDC values back to CalorimeterHits, which replaces CalorimeterHitReco and CalorimeterHitDigi. Downstream clusterization class is now taking output from the full digitization chain for a more realistic simulation.
What is the urgency of this PR?
What kind of change does this PR introduce?
Please check if any of the following apply
First iteration of the CalorimeterCALOROCCalibration is written manually, but AI is used to fix bugs multiple times during development stage when it fails to compile.