Skip to content

Fix truncation / buffer sizes #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vanosg merged 2 commits into from
Dec 19, 2020
Merged

Fix truncation / buffer sizes #1034

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f41da7b
Fix buffer sizes
michaelortmann Oct 5, 2020
042e888
Merge remote-tracking branch 'upstream/develop' into fixbuffersizes
michaelortmann Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/mod/irc.mod/msgcmds.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ static int msg_who(char *nick, char *host, struct userrec *u, char *par)
struct chanset_t *chan;
struct flag_record fr = { FR_GLOBAL | FR_CHAN, 0, 0, 0, 0, 0 };
memberlist *m;
char s[UHOSTLEN], also[512], *info;
char s[NICKLEN + UHOSTLEN], also[512], *info;
Comment thread
michaelortmann marked this conversation as resolved.
int i;

if (!use_info || match_my_nick(nick))
Expand Down Expand Up @@ -431,7 +431,7 @@ static int msg_who(char *nick, char *host, struct userrec *u, char *par)

static int msg_whois(char *nick, char *host, struct userrec *u, char *par)
{
char s[UHOSTLEN], s1[81], *s2;
char s[UHOSTLEN + 1], s1[143], *s2, stime[14];
Comment thread
michaelortmann marked this conversation as resolved.
int ok;
struct chanset_t *chan;
memberlist *m;
Expand Down Expand Up @@ -498,10 +498,10 @@ static int msg_whois(char *nick, char *host, struct userrec *u, char *par)
hand_on_chan(chan, u) || (glob_op(fr) && !chan_deop(fr)) ||
glob_friend(fr) || chan_op(fr) || chan_friend(fr))) {
tt = cr->laston;
strftime(s, 14, "%b %d %H:%M", localtime(&tt));
strftime(stime, sizeof stime, "%b %d %H:%M", localtime(&tt));
ok = 1;
egg_snprintf(s1, sizeof s1, "NOTICE %s :[%s] %s %s on %s", nick,
u2->handle, IRC_LASTSEENAT, s, chan->dname);
u2->handle, IRC_LASTSEENAT, stime, chan->dname);
}
}
}
Expand Down