Fix truncation / buffer sizes - #1034
Merged
Merged
Conversation
vanosg
reviewed
Oct 6, 2020
vanosg
left a comment
Member
There was a problem hiding this comment.
good catches! can you double-check these values and adjust if necessary?
Member
Author
|
Geo: For the uhostlen mess see also #650. Many compiler warnings are currently shaddowed by using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Fix truncation / buffer sizes
Additional description (if needed):
Found with #1028, but can/should be merged independently before #1028.
Test cases demonstrating functionality (if applicable):
it should be possible to demonstrate a truncated notice in
eggdrop/src/mod/irc.mod/msgcmds.c
Line 491 in d5eff2a