Skip to content

Assign dimnames in as.table.datawizard_crosstab() #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elinw wants to merge 4 commits into
base: main
Choose a base branch
from
+45 −31
Open

Assign dimnames in as.table.datawizard_crosstab() #699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b3436df
Assign dimnames in as.table.
elinw Jul 6, 2026
1a7ee37
Add test and update snapshots.
elinw Jul 6, 2026
722dc43
Merge branch 'main' into dimnames
strengejacke Jul 6, 2026
041ef72
fix lint
elinw Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions R/data_tabulate.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -785,6 +785,7 @@ as.table.datawizard_crosstab <- function(
if (.is_grouped_df_xtab(x)) {
x$Group <- NULL
}

# first column contains the row names
row_names <- as.character(x[[1]])
row_names[is.na(row_names)] <- "NA"
Expand All @@ -805,6 +806,10 @@ as.table.datawizard_crosstab <- function(
}
# coerce to table
result <- as.table(as.matrix(x))

dimnames_names <- c(attr(x, "varname"), attr(x, "by"))
names(attributes(result)$dimnames) <- dimnames_names

# if we don't want to simplify the table, we wrap it into a list
if (!simplify) {
result <- list(result)
Expand Down
70 changes: 39 additions & 31 deletions tests/testthat/_snaps/data_tabulate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -925,59 +925,65 @@
as.table(x)
Output
[[1]]
3 4 5
4 1 8 2
6 2 4 1
8 12 0 2
mtcars$gear
mtcars$cyl 3 4 5
4 1 8 2
6 2 4 1
8 12 0 2


---

Code
as.table(x, simplify = TRUE)
Output
3 4 5
4 1 8 2
6 2 4 1
8 12 0 2
mtcars$gear
mtcars$cyl 3 4 5
4 1 8 2
6 2 4 1
8 12 0 2

---

Code
as.table(x)
Output
[[1]]
3 4 5
4 1 8 2
6 2 4 1
8 12 0 2
gear
cyl 3 4 5
4 1 8 2
6 2 4 1
8 12 0 2


---

Code
as.table(x, simplify = TRUE)
Output
3 4 5
4 1 8 2
6 2 4 1
8 12 0 2
gear
cyl 3 4 5
4 1 8 2
6 2 4 1
8 12 0 2

---

Code
as.table(x)
Output
[[1]]
3 4 5
0 15 4 0
1 0 8 5
gear
am 3 4 5
0 15 4 0
1 0 8 5

[[2]]
3 4 5
4 1 8 2
6 2 4 1
8 12 0 2
gear
cyl 3 4 5
4 1 8 2
6 2 4 1
8 12 0 2


---
Expand All @@ -986,15 +992,17 @@
as.table(x)
Output
$`am (0)`
3 4
4 1 2
6 2 2
8 12 0
gear
cyl 3 4
4 1 2
6 2 2
8 12 0

$`am (1)`
4 5
4 6 2
6 2 1
8 0 2
gear
cyl 4 5
4 6 2
6 2 1
8 0 2


1 change: 1 addition & 0 deletions tests/testthat/test-data_tabulate.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,6 +1167,7 @@ test_that("data_tabulate, table methods", {
x <- data_tabulate(mtcars$cyl, mtcars$gear)
expect_type(as.table(x), "list")
expect_s3_class(as.table(x, simplify = TRUE), "table")
expect_named(dimnames(as.table(x)[[1]]), c("mtcars$cyl", "mtcars$gear"))
expect_snapshot(as.table(x))
expect_snapshot(as.table(x, simplify = TRUE))

Expand Down
Loading