Assign dimnames in as.table.datawizard_crosstab()#699
Open
elinw wants to merge 4 commits into
Open
Conversation
etiennebacher
requested changes
Jul 6, 2026
etiennebacher
left a comment
Member
There was a problem hiding this comment.
Thanks, LGTM, can you add an item in NEWS.md and bump the last version number in DESCRIPTION?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
as.table.datawizard_crosstab()function produces a table in which thedimnamesare unnamed. When making a table usingtable()the names are created, but as.table() does not have an argument to do it directly. Having the dimnames set is very helpful when using tables for further analysis (likeloglin()).