Skip to content

fix[parser]: Prevent adbuffet unwrapped ad to override parent adpod sequence #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ZacharieTFR merged 1 commit into from
May 12, 2026
Merged

fix[parser]: Prevent adbuffet unwrapped ad to override parent adpod sequence #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 38 additions & 12 deletions spec/vast_parser.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,24 +247,50 @@ describe('VASTParser', () => {

it('it replaces the ad sequence with the value of the wrapper sequence if it contains only one ad', () => {
jest.spyOn(VastParser, 'parseVastXml').mockReturnValue([{ sequence: 2 }]);
return VastParser.parse(wrapperXml, { wrapperSequence: 4 }).then(
(ads) => {
expect(ads[0].sequence).toEqual(4);
}
);
return VastParser.parse(wrapperXml, {
wrapperDepth: 1,
wrapperSequence: 4,
}).then((ads) => {
expect(ads[0].sequence).toEqual(4);
});
Comment thread
ZacharieTFR marked this conversation as resolved.
});

it('does not keep wrapper sequence value when wrapper contain an adpod', () => {
jest
.spyOn(VastParser, 'parseVastXml')
.mockReturnValue([{ sequence: 1 }, { sequence: 2 }, { sequence: 3 }]);
return VastParser.parse(wrapperXml, { wrapperSequence: 4 }).then(
(ads) => {
expect(ads[0].sequence).toEqual(1);
expect(ads[1].sequence).toEqual(2);
expect(ads[2].sequence).toEqual(3);
}
);
return VastParser.parse(wrapperXml, {
wrapperDepth: 1,
wrapperSequence: 4,
}).then((ads) => {
expect(ads[0].sequence).toEqual(1);
expect(ads[1].sequence).toEqual(2);
expect(ads[2].sequence).toEqual(3);
});
});

it('keeps child sequences for adpod when wrapper has no sequence', () => {
jest
.spyOn(VastParser, 'parseVastXml')
.mockReturnValue([{ sequence: 1 }, { sequence: 2 }, { sequence: 3 }]);
return VastParser.parse(wrapperXml, {
wrapperDepth: 1,
wrapperSequence: null,
}).then((ads) => {
expect(ads[0].sequence).toEqual(1);
expect(ads[1].sequence).toEqual(2);
expect(ads[2].sequence).toEqual(3);
});
});

it('clears child sequence for single-ad wrapper without sequence', () => {
jest.spyOn(VastParser, 'parseVastXml').mockReturnValue([{ sequence: 1 }]);
return VastParser.parse(wrapperXml, {
wrapperDepth: 1,
wrapperSequence: null,
}).then((ads) => {
expect(ads[0].sequence).toBeNull();
});
});
});

Expand Down
6 changes: 1 addition & 5 deletions src/parser/vast_parser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,11 +299,7 @@ export class VASTParser extends EventEmitter {
- Inline sequence 3
*/

if (
ads.length === 1 &&
wrapperSequence !== undefined &&
wrapperSequence !== null
) {
if (ads.length === 1 && wrapperDepth > 0 && wrapperSequence !== undefined) {
Comment thread
ZacharieTFR marked this conversation as resolved.
ads[0].sequence = wrapperSequence;
}
if (resolveAll === false) {
Expand Down
Loading