Repository navigation
fix[parser]: Prevent adbuffet unwrapped ad to override parent adpod sequence - #508
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes sequence handling during wrapper unwrapping so that a wrapper that is not part of an AdPod (no wrapper sequence / “ad buffet”) cannot leak a child inline ad’s sequence into the final resolved ad list and cause incorrect AdPod ordering.
Changes:
- Update
VASTParser.parse()to apply the wrapper’s sequence to a single unwrapped ad only when resolving wrappers (wrapperDepth > 0), including clearing the child sequence when the wrapper has no sequence. - Update and extend Jest coverage for wrapper/sequence interactions (single-ad wrapper, wrapper with adpod, wrapper with null sequence).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/parser/vast_parser.js | Adjusts the sequence override condition to depend on wrapper resolution depth and allow clearing sequence when wrapper has no sequence. |
| spec/vast_parser.spec.js | Updates existing tests and adds new cases to validate correct sequence behavior for wrappers with/without sequence and adpods. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
clementFrancon
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a Wrapper inside an AdPod had no sequence (=part of ad buffet), the unwrapped Inline ad could still carry its own sequence causing the final list to treat it as an AdPod member and reorder it incorrectly.
Type