Add MountDataStore default-true to Job constructors - #29
Merged
ianmcorvidae merged 1 commit intoJul 21, 2026
Merged
Conversation
MountDataStore already existed on the Job struct but was always its zero value (false) when constructed via New() or NewAnalysis(). Set it to true in both constructors so that jobs created from JSON with the field absent behave as if the data store is to be mounted, matching the historical default.
Member
Author
|
I'm going to go ahead and merge this so I can pull the (small) change into the app-exposer PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MountDataStore already existed on the Job struct but was always its zero value (false) when constructed via New() or NewAnalysis(). Set it to true in both constructors so that jobs created from JSON with the field absent behave as if the data store is to be mounted, matching the historical default.