Add mount data store toggle to VICE app launch Advanced Settings - #713
Merged
ianmcorvidae merged 3 commits intoJul 23, 2026
Merged
Conversation
Add a checkbox to the Advanced Settings step of the app launch wizard, visible only for interactive (VICE) apps. The checkbox is labelled "Mount data store in analysis" and defaults to checked (true), preserving existing behaviour. Helper text explains the difference between the direct-mount and copy-in/copy-out modes. Wire mount_data_store into initAppLaunchValues (default true) and formatSubmission so it is included in the POST body to /analyses.
psarando
approved these changes
Jul 21, 2026
psarando
left a comment
psarando
left a comment
Member
There was a problem hiding this comment.
LGTM 👍
Though I would also like to see the stories/apps/launch/JupyterLabNoParams.js story updated (or probably just the stories/apps/launch/data/JupyterLabNoParamsApp.js with the interactive type field) so that this checkbox can be previewed in Storybook.
Member
Author
|
That's a good idea. I'll have my statistics model have a look at updating that |
psarando
approved these changes
Jul 21, 2026
psarando
left a comment
psarando
left a comment
Member
There was a problem hiding this comment.
Works as expected in Storybook now 👍 🎉
Member
Author
|
Thanks for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a checkbox to the Advanced Settings step of the app launch wizard, visible only for interactive (VICE) apps. The checkbox is labelled "Mount data store in analysis" and defaults to checked (true), preserving existing behaviour. Helper text explains the difference between the direct-mount and copy-in/copy-out modes.
Wire mount_data_store into initAppLaunchValues (default true) and formatSubmission so it is included in the POST body to /analyses.
depends on cyverse-de/app-exposer#160 cyverse-de/apps#301 and cyverse-de/model#29