feat: add qbench repeat median sampling - #47
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds repeatable sampling to the qbench benchmark runner so timing output can report the (upper) median across multiple full samples, while keeping the existing quickcoffee.qbench.v1 schema and adding CLI/test/docs coverage.
Changes:
- Add
--repeat N(default1) toqbenchand compute per-phase upper-median timings across N complete samples. - Extend JSON and text outputs with a
repeatfield/key and validate--repeatis a positive integer (exit code2otherwise). - Document the new behavior via RFC 0105 and update README/PERFORMANCE docs; expand CLI integration tests for repeat.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/cli_tools.rs | Extends CLI integration coverage to assert repeat appears in both JSON/text output and validates --repeat 0 fails. |
| src/bin/qbench.rs | Implements --repeat, collects per-sample timings, and reports upper-median *_ns values while emitting repeat in outputs. |
| RFCs/0105-qbench-repeat-median.md | Defines the repeat + upper-median sampling behavior and acceptance criteria. |
| RFCs/0000-project-scope.md | Updates the documented RFC coverage range to include RFC 0105. |
| README.md | Updates top-level RFC range reference to RFC 0105. |
| PERFORMANCE.md | Documents --repeat 3 usage for median-of-three reporting. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tiye
added a commit
that referenced
this pull request
Aug 23, 2026
* fix: preserve qdocco block comments as code * docs: regenerate manuals for qdocco block comments * feat: add qbench repeat median sampling (#47) * feat: add qbench repeat median sampling * docs: document qbench repeat sampling * fix: preserve multiline qdocco block comments * fix: satisfy clippy in qdocco block parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--repeat Nand report upper median timings across complete samplesValidation
make checkgit diff --checkThis PR is stacked on PR #46 and should remain unmerged with the rest of the chain.