chore: gate checks on cargo package - #48
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a release-readiness gate to ensure the crate can be packaged according to Cargo’s publish manifest, and wires that check into the standard make check verification path (with accompanying RFC/documentation updates).
Changes:
- Add RFC 0106 describing a “crate package verification” acceptance gate.
- Extend
make checkto runcargo package --lockedvia a newmake packagetarget. - Update project scope and README to reference RFC 0106 as the latest implemented RFC.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
RFCs/0106-package-verification-gate.md |
Introduces the new package verification gate RFC and its rationale. |
RFCs/0000-project-scope.md |
Updates the “implemented RFCs up to …” statement to include RFC 0106. |
README.md |
Updates the RFC range reference to point to RFC 0106. |
Makefile |
Adds package target (cargo package --locked) and includes it in check. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Base automatically changed from
feat/qbench-repeat-median
to
fix/qdocco-block-comment-code
August 22, 2026 17:51
tiye
force-pushed
the
chore/package-verification-gate
branch
3 times, most recently
from
August 22, 2026 18:46
821f325 to
13f9f37
Compare
Base automatically changed from
fix/qdocco-block-comment-code
to
feat/qbench-schema-version
August 23, 2026 04:12
tiye
force-pushed
the
feat/qbench-schema-version
branch
from
August 23, 2026 06:16
c45a03c to
3f9263c
Compare
Base automatically changed from
feat/qbench-schema-version
to
feat/program-fingerprint
August 23, 2026 06:18
tiye
force-pushed
the
chore/package-verification-gate
branch
from
August 23, 2026 06:21
13f9f37 to
4acec4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo package --lockedinmake checkValidation
make checkcargo package --lockedgit diff --checkThis PR is stacked on PR #47 and should remain unmerged with the rest of the chain.