Skip to content

chore: gate checks on cargo package - #48

Merged
tiye merged 1 commit into
feat/program-fingerprintfrom
chore/package-verification-gate
Aug 23, 2026
Merged

chore: gate checks on cargo package#48
tiye merged 1 commit into
feat/program-fingerprintfrom
chore/package-verification-gate

Conversation

@tiye

@tiye tiye commented Aug 22, 2026

Copy link
Copy Markdown
Member

Summary

  • add RFC 0106 for crate package verification
  • include cargo package --locked in make check
  • make CI compile the exact published package contents

Validation

  • make check
  • cargo package --locked
  • git diff --check

This PR is stacked on PR #47 and should remain unmerged with the rest of the chain.

Copilot AI lite review requested due to automatic review settings August 22, 2026 15:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a release-readiness gate to ensure the crate can be packaged according to Cargo’s publish manifest, and wires that check into the standard make check verification path (with accompanying RFC/documentation updates).

Changes:

  • Add RFC 0106 describing a “crate package verification” acceptance gate.
  • Extend make check to run cargo package --locked via a new make package target.
  • Update project scope and README to reference RFC 0106 as the latest implemented RFC.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
RFCs/0106-package-verification-gate.md Introduces the new package verification gate RFC and its rationale.
RFCs/0000-project-scope.md Updates the “implemented RFCs up to …” statement to include RFC 0106.
README.md Updates the RFC range reference to point to RFC 0106.
Makefile Adds package target (cargo package --locked) and includes it in check.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread RFCs/0106-package-verification-gate.md Outdated
Comment thread Makefile Outdated
Base automatically changed from feat/qbench-repeat-median to fix/qdocco-block-comment-code August 22, 2026 17:51
@tiye
tiye force-pushed the chore/package-verification-gate branch 3 times, most recently from 821f325 to 13f9f37 Compare August 22, 2026 18:46
Base automatically changed from fix/qdocco-block-comment-code to feat/qbench-schema-version August 23, 2026 04:12
@tiye
tiye force-pushed the feat/qbench-schema-version branch from c45a03c to 3f9263c Compare August 23, 2026 06:16
Base automatically changed from feat/qbench-schema-version to feat/program-fingerprint August 23, 2026 06:18
@tiye
tiye force-pushed the chore/package-verification-gate branch from 13f9f37 to 4acec4c Compare August 23, 2026 06:21
@tiye
tiye merged commit 4fca6f8 into feat/program-fingerprint Aug 23, 2026
2 checks passed
@tiye
tiye deleted the chore/package-verification-gate branch August 23, 2026 06:24
@tiye
tiye restored the chore/package-verification-gate branch August 23, 2026 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants