fix: preserve qdocco block comments as code - #46
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates qdocco to preserve CoffeeScript block comments in generated HTML/Markdown code, with regression tests and RFC documentation.
Changes:
- Adds RFC 0104 and updates project references.
- Adds HTML and Markdown regression coverage.
- Updates prose/code classification.
The multiline block-comment handling remains unresolved: qdocco must track block-comment state across render passes for both HTML and Markdown.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tests/cli_tools.rs |
Adds block-comment regression tests. |
src/bin/qdocco.rs |
Adjusts prose/code classification; multiline state handling requires changes. |
RFCs/0104-qdocco-block-comments.md |
Documents block-comment boundary behavior. |
RFCs/0000-project-scope.md |
Registers RFC 0104. |
README.md |
Links the latest RFC. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
* feat: add qbench repeat median sampling * docs: document qbench repeat sampling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
### ... ###CoffeeScript block comments in generated codeValidation
make checkgit diff --checkThis PR is stacked on PR #45 and should remain unmerged with the rest of the chain.