Skip to content

feat: version qbench machine output - #45

Merged
tiye merged 1 commit into
feat/program-fingerprintfrom
feat/qbench-schema-version
Aug 23, 2026
Merged

feat: version qbench machine output#45
tiye merged 1 commit into
feat/program-fingerprintfrom
feat/qbench-schema-version

Conversation

@tiye

@tiye tiye commented Aug 22, 2026

Copy link
Copy Markdown
Member

Summary

  • add RFC 0103 for versioned qbench machine output
  • emit stable schema and crate version fields in JSON and text modes
  • preserve existing timing fields and total-nanosecond semantics

Validation

  • make check
  • git diff --check

This PR is stacked on PR #44 and should remain unmerged with the rest of the chain.

Copilot AI lite review requested due to automatic review settings August 22, 2026 15:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a versioned, machine-readable schema marker to qbench output, ensuring consumers can reliably detect the output contract and crate version across JSON and text modes.

Changes:

  • Introduces RFC 0103 defining qbench output schema + version fields and their stability rules.
  • Updates qbench to emit schema=quickcoffee.qbench.v1 and the crate version in both JSON and text outputs.
  • Extends CLI integration tests to validate presence of the new fields (with a recommendation to strengthen per-line checks for text output).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/cli_tools.rs Updates integration test expectations to include schema and version for qbench output.
src/bin/qbench.rs Adds schema/version emission to both JSON and text output formats.
RFCs/0103-qbench-schema-version.md New RFC specifying the versioned qbench machine output contract.
RFCs/0000-project-scope.md Updates the documented RFC coverage range to include RFC 0103.
README.md Updates the README’s “implemented RFCs” reference to point to RFC 0103.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/cli_tools.rs
@tiye
tiye force-pushed the fix/qtest-canonical-file-dedup branch from fa62037 to 73ff0dc Compare August 23, 2026 05:04
Base automatically changed from fix/qtest-canonical-file-dedup to feat/program-fingerprint August 23, 2026 05:05
@tiye
tiye force-pushed the feat/qbench-schema-version branch from c45a03c to 3f9263c Compare August 23, 2026 06:16
@tiye
tiye merged commit 95e5d50 into feat/program-fingerprint Aug 23, 2026
2 checks passed
@tiye
tiye deleted the feat/qbench-schema-version branch August 23, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants