feat: version qbench machine output - #45
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a versioned, machine-readable schema marker to qbench output, ensuring consumers can reliably detect the output contract and crate version across JSON and text modes.
Changes:
- Introduces RFC 0103 defining
qbenchoutputschema+versionfields and their stability rules. - Updates
qbenchto emitschema=quickcoffee.qbench.v1and the crateversionin both JSON and text outputs. - Extends CLI integration tests to validate presence of the new fields (with a recommendation to strengthen per-line checks for text output).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/cli_tools.rs | Updates integration test expectations to include schema and version for qbench output. |
| src/bin/qbench.rs | Adds schema/version emission to both JSON and text output formats. |
| RFCs/0103-qbench-schema-version.md | New RFC specifying the versioned qbench machine output contract. |
| RFCs/0000-project-scope.md | Updates the documented RFC coverage range to include RFC 0103. |
| README.md | Updates the README’s “implemented RFCs” reference to point to RFC 0103. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tiye
force-pushed
the
fix/qtest-canonical-file-dedup
branch
from
August 23, 2026 05:04
fa62037 to
73ff0dc
Compare
Base automatically changed from
fix/qtest-canonical-file-dedup
to
feat/program-fingerprint
August 23, 2026 05:05
tiye
force-pushed
the
feat/qbench-schema-version
branch
from
August 23, 2026 06:16
c45a03c to
3f9263c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
schemaand crateversionfields in JSON and text modesValidation
make checkgit diff --checkThis PR is stacked on PR #44 and should remain unmerged with the rest of the chain.