Skip to content

Added ROOT dictionaries in DataFormats #51739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmsbuild merged 2 commits into from
Aug 22, 2026
Merged

Added ROOT dictionaries in DataFormats #51739

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40fca09
Added required dictionaries explicitly to fix unnecessary runtime aut…
alexstrel Aug 19, 2026
489d906
addressed PR comments
alexstrel Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions DataFormats/BTauReco/src/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
<class name="reco::SecondaryVertexTagInfoRefVector"/>
<class name="edm::Wrapper<reco::SecondaryVertexTagInfoCollection>"/>

<class name="reco::TemplatedSecondaryVertexTagInfo<reco::IPTagInfo<vector<edm::Ptr<reco::io_v1::Candidate> >,reco::io_v1::JetTagInfo>,reco::io_v1::VertexCompositePtrCandidate>"/>

<class name="reco::TemplatedSecondaryVertexTagInfo<reco::CandIPTagInfo,reco::io_v1::VertexCompositePtrCandidate>::VertexData"/>
<class name="std::vector<reco::CandSecondaryVertexTagInfo::VertexData>"/>
<class name="reco::CandSecondaryVertexTagInfo"/>
Expand Down
1 change: 1 addition & 0 deletions DataFormats/EgammaCandidates/src/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@

<class name="std::vector<reco::io_v1::Photon>"/>
<class name="edm::Wrapper<std::vector<reco::io_v1::Photon> >"/>
<class name="edm::refhelper::FindUsingAdvance<vector<reco::io_v1::Photon>,reco::io_v1::Photon>"/>
<class name="edm::Ref<std::vector<reco::io_v1::Photon>,reco::io_v1::Photon,edm::refhelper::FindUsingAdvance<std::vector<reco::io_v1::Photon>,reco::io_v1::Photon> >"/>
<class name="std::vector<edm::Ref<std::vector<reco::io_v1::Photon>,reco::io_v1::Photon,edm::refhelper::FindUsingAdvance<std::vector<reco::io_v1::Photon>,reco::io_v1::Photon> > >"/>
<class name="edm::RefProd<std::vector<reco::io_v1::Photon> >"/>
Expand Down
1 change: 1 addition & 0 deletions DataFormats/EgammaReco/src/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<lcgdict>

<class name="std::vector<reco::io_v1::ElectronSeed::PMVars>"/>

@makortel makortel Aug 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this line below

cmssw/DataFormats/EgammaReco/src/classes_def.xml

Line 97 in 40fca09

<class name="std::vector<reco::io_v1::ElectronSeed>"/>

@alexstrel alexstrel Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<class name="edm::RefToBase<reco::io_v1::CaloCluster>" rntupleStreamerMode="true"/>
<class name="edm::reftobase::BaseHolder<reco::io_v1::CaloCluster>"/>
<class name="edm::reftobase::IndirectHolder<reco::io_v1::CaloCluster>" />
Expand Down
1 change: 1 addition & 0 deletions DataFormats/HcalIsolatedTrack/src/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<class name="reco::IsolatedPixelTrackCandidateRefProd"/>
<class name="edm::Wrapper<reco::IsolatedPixelTrackCandidateCollection>"/>
<class name="edm::reftobase::Holder<reco::io_v1::Candidate, edm::Ref<std::vector<reco::IsolatedPixelTrackCandidate>,reco::IsolatedPixelTrackCandidate,edm::refhelper::FindUsingAdvance<std::vector<reco::IsolatedPixelTrackCandidate>,reco::IsolatedPixelTrackCandidate> > >" />
<class name="edm::refhelper::FindUsingAdvance<std::vector<reco::IsolatedPixelTrackCandidate>,reco::IsolatedPixelTrackCandidate>"/>
<class name="edm::Ref<std::vector<reco::IsolatedPixelTrackCandidate>,reco::IsolatedPixelTrackCandidate,edm::refhelper::FindUsingAdvance<std::vector<reco::IsolatedPixelTrackCandidate>,reco::IsolatedPixelTrackCandidate> >"/>
<class name="std::vector<edm::Ref<std::vector<reco::IsolatedPixelTrackCandidate>,reco::IsolatedPixelTrackCandidate,edm::refhelper::FindUsingAdvance<std::vector<reco::IsolatedPixelTrackCandidate>,reco::IsolatedPixelTrackCandidate> > >"/>

Expand Down
1 change: 1 addition & 0 deletions DataFormats/L1TCorrelator/src/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
</class>
<class name="std::vector<l1t::io_v1::TkEm>"/>
<class name="edm::Wrapper<std::vector<l1t::io_v1::TkEm> >"/>
<class name="edm::refhelper::FindUsingAdvance<std::vector<l1t::io_v1::TkElectron>,l1t::io_v1::TkElectron>"/>

@makortel makortel Aug 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this above the line

cmssw/DataFormats/L1TCorrelator/src/classes_def.xml

Line 49 in 40fca09

<class name="edm::Ref<std::vector<l1t::io_v1::TkElectron>,l1t::io_v1::TkElectron,edm::refhelper::FindUsingAdvance<std::vector<l1t::io_v1::TkElectron>,l1t::io_v1::TkElectron> >"/>

@alexstrel alexstrel Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

<class name="edm::Ref<std::vector<l1t::io_v1::TkEm>,l1t::io_v1::TkEm,edm::refhelper::FindUsingAdvance<std::vector<l1t::io_v1::TkEm>,l1t::io_v1::TkEm> >"/>
<class name="std::vector<edm::Ref<std::vector<l1t::io_v1::TkEm>,l1t::io_v1::TkEm,edm::refhelper::FindUsingAdvance<std::vector<l1t::io_v1::TkEm>,l1t::io_v1::TkEm> > >"/>
<class name="edm::RefProd<l1t::TkEmCollection>" />
Expand Down
1 change: 1 addition & 0 deletions DataFormats/L1TMuon/src/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
<class name="edm::Wrapper<L1MuKBMTCombinedStubCollection >"/>

<class name="edm::Ref<L1MuKBMTCombinedStubCollection>" splitLevel="0"/>
<class name="std::vector<edm::Ref<L1MuKBMTCombinedStubCollection>>"/>
<class name="edm::Wrapper<edm::Ref<L1MuKBMTCombinedStubCollection > >"/>


Expand Down
2 changes: 2 additions & 0 deletions DataFormats/L1TParticleFlow/src/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
<class name="l1t::RegionalOutput<l1t::PFCandidateCollection>" />
<class name="edm::Wrapper<l1t::RegionalOutput<l1t::PFCandidateCollection>>" />

<class name="edm::refhelper::FindUsingAdvance<std::vector<l1t::io_v1::PFJet>,l1t::io_v1::PFJet>"/>

@makortel makortel Aug 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move this above the line

cmssw/DataFormats/L1TParticleFlow/src/classes_def.xml

Line 39 in 40fca09

<class name="edm::Ref<l1t::PFJetCollection>" />

@alexstrel alexstrel Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


<class name="l1t::io_v1::PFJet" ClassVersion="3">
<version ClassVersion="3" checksum="1164493406"/>
</class>
Expand Down
1 change: 1 addition & 0 deletions DataFormats/ParticleFlowReco/src/classes_def_2.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@
<class name="edm::ValueMap<reco::PreIdRef>"/>
<class name="std::vector<reco::PreIdRef>"/>
<class name="edm::Wrapper<edm::ValueMap<reco::PreIdRef> >"/>
<class name="edm::refhelper::FindUsingAdvance<vector<reco::io_v1::PreId>,reco::io_v1::PreId>" />
<class name="edm::Ref<std::vector<reco::io_v1::PreId>,reco::io_v1::PreId,edm::refhelper::FindUsingAdvance<std::vector<reco::io_v1::PreId>,reco::io_v1::PreId> >" />

<class name="reco::PFBlockElementSuperCluster" ClassVersion="3">
Expand Down
3 changes: 3 additions & 0 deletions DataFormats/RecoCandidate/src/classes_def.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@
<!-- <field name="fixed_" transient="true"/> -->
</class>

<class name="std::pair<reco::isodeposit::Direction::Distance,float>"/>
<class name="std::map<reco::isodeposit::Direction::Distance,float>"/>

@makortel makortel Aug 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these below the line

cmssw/DataFormats/RecoCandidate/src/classes_def.xml

Line 130 in 40fca09

<class name="std::multimap<reco::io_v1::IsoDeposit::Direction::Distance,float>"/>

@alexstrel alexstrel Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


<class name="std::vector<reco::io_v1::RecoChargedCandidate>"/>
<class name="edm::Wrapper<std::vector<reco::io_v1::RecoChargedCandidate> >"/>
<class name="edm::Ref<std::vector<reco::io_v1::RecoChargedCandidate>,reco::io_v1::RecoChargedCandidate,edm::refhelper::FindUsingAdvance<std::vector<reco::io_v1::RecoChargedCandidate>,reco::io_v1::RecoChargedCandidate> >"/>
Expand Down