Added ROOT dictionaries in DataFormats by alexstrel · Pull Request #51739 · cms-sw/cmssw

alexstrel · 2026-08-19T20:04:54Z

This PR adds ROOT dictionary instantiations identified during the investigation of ROOT autoparsing and memory usage. The changes cover several DataFormats packages, including BTauReco, EgammaCandidates, EgammaReco, HcalIsolatedTrack, L1TCorrelator, L1TMuon, L1TParticleFlow, ParticleFlowReco, and RecoCandidate.
The goal is to provide the required dictionaries explicitly and avoid unnecessary runtime autoparsing.

Resolves cms-sw/framework-team#2398

…oparsing.

cmsbuild · 2026-08-19T20:05:18Z

cms-bot internal usage

cmsbuild · 2026-08-19T20:06:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51739/50669

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/BTauReco/src/classes_def.xml modified in PR(s): Add HLT_DoubleMediumPFPuppiParTTauh30_eta2p1 path #51705
- File DataFormats/EgammaReco/src/classes_def.xml modified in PR(s): Adding in slimmed superclusters for EGM efficiency measurements to Mini #42007, Heterogeneous Alpaka implementation of electron pixel seed-matching #51200
- File DataFormats/L1TCorrelator/src/classes_def.xml modified in PR(s): Phase2 L1T: Correlator development for AR2026 #51270
- File DataFormats/L1TParticleFlow/src/classes_def.xml modified in PR(s): Phase2 L1T: Correlator development for AR2026 #51270
- File DataFormats/ParticleFlowReco/src/classes_def_2.xml modified in PR(s): Particle Flow cluster validation in ECAL #50292

cmsbuild · 2026-08-19T20:07:16Z

A new Pull Request was created by @alexstrel for master.

It involves the following packages:

DataFormats/BTauReco (reconstruction)
DataFormats/EgammaCandidates (reconstruction)
DataFormats/EgammaReco (reconstruction)
DataFormats/HcalIsolatedTrack (reconstruction)
DataFormats/L1TCorrelator (l1)
DataFormats/L1TMuon (l1)
DataFormats/L1TParticleFlow (l1)
DataFormats/ParticleFlowReco (reconstruction)
DataFormats/RecoCandidate (reconstruction)

@BenjaminRS, @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @quinnanm, @srimanob can you please review it and eventually sign? Thanks.
@AlexDeMoor, @Ming-Yan, @Prasant1993, @Sam-Harper, @Senphy, @a-kapoor, @afiqaize, @andrzejnovak, @bsunanda, @castaned, @eyigitba, @gouskos, @hatakeyamak, @jainshilpi, @lgray, @missirol, @mmusich, @pavlo-kashko, @philippgadow, @ram1123, @rovere, @sameasy, @sobhatta, @thomreis, @varuns23 this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

makortel

Few suggestions to have related types closer each other in the XML file. But please wait for the build of #51200 (comment) to succeed before updating this PR.

makortel · 2026-08-19T21:13:04Z

@@ -1,5 +1,6 @@
 <lcgdict>

+  <class name="std::vector<reco::io_v1::ElectronSeed::PMVars>"/>	


Please move this line below

cmssw/DataFormats/EgammaReco/src/classes_def.xml

Line 97 in 40fca09

<class name="std::vector<reco::io_v1::ElectronSeed>"/>

makortel · 2026-08-19T21:14:17Z

  </class>
  <class name="std::vector<l1t::io_v1::TkEm>"/>
  <class name="edm::Wrapper<std::vector<l1t::io_v1::TkEm> >"/>
+  <class name="edm::refhelper::FindUsingAdvance<std::vector<l1t::io_v1::TkElectron>,l1t::io_v1::TkElectron>"/>


Please move this above the line

cmssw/DataFormats/L1TCorrelator/src/classes_def.xml

Line 49 in 40fca09

<class name="edm::Ref<std::vector<l1t::io_v1::TkElectron>,l1t::io_v1::TkElectron,edm::refhelper::FindUsingAdvance<std::vector<l1t::io_v1::TkElectron>,l1t::io_v1::TkElectron> >"/>

makortel · 2026-08-19T21:15:04Z

  <class name="l1t::RegionalOutput<l1t::PFCandidateCollection>" />
  <class name="edm::Wrapper<l1t::RegionalOutput<l1t::PFCandidateCollection>>" />

+  <class name="edm::refhelper::FindUsingAdvance<std::vector<l1t::io_v1::PFJet>,l1t::io_v1::PFJet>"/>


Please move this above the line

cmssw/DataFormats/L1TParticleFlow/src/classes_def.xml

Line 39 in 40fca09

<class name="edm::Ref<l1t::PFJetCollection>" />

makortel · 2026-08-19T21:15:48Z

+  <class name="std::pair<reco::isodeposit::Direction::Distance,float>"/>
+  <class name="std::map<reco::isodeposit::Direction::Distance,float>"/>


Please move these below the line

cmssw/DataFormats/RecoCandidate/src/classes_def.xml

Line 130 in 40fca09

<class name="std::multimap<reco::io_v1::IsoDeposit::Direction::Distance,float>"/>

cmsbuild · 2026-08-20T18:23:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51739/50681

There are other open Pull requests which might conflict with changes you have proposed:
- File DataFormats/BTauReco/src/classes_def.xml modified in PR(s): Add HLT_DoubleMediumPFPuppiParTTauh30_eta2p1 path #51705
- File DataFormats/EgammaReco/src/classes_def.xml modified in PR(s): Adding in slimmed superclusters for EGM efficiency measurements to Mini #42007, Heterogeneous Alpaka implementation of electron pixel seed-matching #51200
- File DataFormats/L1TCorrelator/src/classes_def.xml modified in PR(s): Phase2 L1T: Correlator development for AR2026 #51270
- File DataFormats/L1TParticleFlow/src/classes_def.xml modified in PR(s): Phase2 L1T: Correlator development for AR2026 #51270
- File DataFormats/ParticleFlowReco/src/classes_def_2.xml modified in PR(s): Particle Flow cluster validation in ECAL #50292

cmsbuild · 2026-08-20T18:23:55Z

Pull request #51739 was updated. @BenjaminRS, @Moanwar, @cmsbuild, @jfernan2, @mandrenguyen, @quinnanm, @srimanob can you please check and sign again.

makortel · 2026-08-21T13:52:10Z

@cmsbuild, please test

cmsbuild · 2026-08-21T15:39:13Z

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2876f/55493/summary.html
COMMIT: 489d906
CMSSW: CMSSW_20_1_X_2026-08-21-1100/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51739/55493/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 45
DQMHistoTests: Total histograms compared: 3592269
DQMHistoTests: Total failures: 3
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3592248
DQMHistoTests: Total skipped: 18
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
Checked 195 log files, 163 edm output root files, 45 DQM output files
TriggerResults: no differences found

Max Memory Comparisons exceeding threshold

@cms-sw/core-l2 , I found 21 workflow step(s) with memory usage exceeding the error threshold:

Expand to see workflows ...

Error: Workflow 25.0_TTbar step5 max memory diff -54.8 exceeds +/- 30.0 MiB
Error: Workflow 1001.0_RunMinBias2011A step3 max memory diff -53.4 exceeds +/- 30.0 MiB
Error: Workflow 2023.0020001_RunJetMET02023D_10k step3 max memory diff -30.0 exceeds +/- 30.0 MiB
Error: Workflow 2024.0000001_RunZeroBias2024B_10k step3 max memory diff -30.0 exceeds +/- 30.0 MiB
Error: Workflow 2024.0010001_RunJetMET02024C_10k step3 max memory diff -30.0 exceeds +/- 30.0 MiB
Error: Workflow 2024.0020001_RunEGamma02024D_10k step3 max memory diff -30.0 exceeds +/- 30.0 MiB
Error: Workflow 2024.0030001_RunDisplacedJet2024E_10k step3 max memory diff -30.1 exceeds +/- 30.0 MiB
Error: Workflow 2024.0040001_RunPark2MuonLowMass02024F_10k step3 max memory diff -30.0 exceeds +/- 30.0 MiB
Error: Workflow 2024.0050001_RunBTagMu2024G_10k step3 max memory diff -30.0 exceeds +/- 30.0 MiB
Error: Workflow 2024.0060001_RunMuon02024H_10k step3 max memory diff -30.0 exceeds +/- 30.0 MiB
Error: Workflow 2024.0070001_RunTau2024I_10k step3 max memory diff -30.1 exceeds +/- 30.0 MiB
Error: Workflow 11634.0_TTbar_14TeV+2022 step5 max memory diff -46.6 exceeds +/- 30.0 MiB
Error: Workflow 12434.0_TTbar_14TeV+2023 step5 max memory diff -46.6 exceeds +/- 30.0 MiB
Error: Workflow 12834.0_TTbar_14TeV+2024 step5 max memory diff -46.6 exceeds +/- 30.0 MiB
Error: Workflow 12846.0_ZEE_14+2024 step5 max memory diff -46.6 exceeds +/- 30.0 MiB
Error: Workflow 16834.0_TTbar_14TeV+2025 step5 max memory diff -46.6 exceeds +/- 30.0 MiB
Error: Workflow 18434.0_TTbar_14TeV+2026 step5 max memory diff -44.1 exceeds +/- 30.0 MiB
Error: Workflow 37634.0_TTbar_14TeV+Run4D127 step5 max memory diff -34.3 exceeds +/- 30.0 MiB
Error: Workflow 37634.911_TTbar_14TeV+Run4D127_DD4hep step5 max memory diff -34.3 exceeds +/- 30.0 MiB
Error: Workflow 37696.0_CloseByPGun_CE_E_Front_120um+Run4D127 step5 max memory diff -34.3 exceeds +/- 30.0 MiB
Error: Workflow 37700.0_CloseByPGun_CE_H_Coarse_Scint+Run4D127 step5 max memory diff -34.3 exceeds +/- 30.0 MiB

makortel · 2026-08-21T16:12:26Z

@cms-sw/l1-l2 @cms-sw/reconstruction-l2 Note that strictly speaking this PR is independent from #51200 and can (IMHO should) be reviewed and merged separately.

Moanwar · 2026-08-21T17:27:01Z

Hi @alexstrel, thanks a lot for the PR! It’s nice to see the reduction in memory usage. Just for my understanding, is this reduction expected? And why is it specifically in Step 5? It’s a little bit unclear to me.

makortel · 2026-08-21T17:51:23Z

Just for my understanding, is this reduction expected? And why is it specifically in Step 5? It’s a little bit unclear to me.

Generally more compiled dictionaries for data types that ROOT serializes as opposed to header parsing can reduce memory. In several of the workflows the step 5 is ALCA. Could be related to the data types that are being read/written there.

Moanwar · 2026-08-21T18:34:27Z

Just for my understanding, is this reduction expected? And why is it specifically in Step 5? It’s a little bit unclear to me.

Generally more compiled dictionaries for data types that ROOT serializes as opposed to header parsing can reduce memory. In several of the workflows the step 5 is ALCA. Could be related to the data types that are being read/written there.

Then I would be greedy and ask if we can add that to more DataFormats packages ?

makortel · 2026-08-21T18:42:56Z

Just for my understanding, is this reduction expected? And why is it specifically in Step 5? It’s a little bit unclear to me.

Generally more compiled dictionaries for data types that ROOT serializes as opposed to header parsing can reduce memory. In several of the workflows the step 5 is ALCA. Could be related to the data types that are being read/written there.

Then I would be greedy and ask if we can add that to more DataFormats packages ?

Add what exactly?

Moanwar · 2026-08-21T18:55:19Z

Just for my understanding, is this reduction expected? And why is it specifically in Step 5? It’s a little bit unclear to me.

Generally more compiled dictionaries for data types that ROOT serializes as opposed to header parsing can reduce memory. In several of the workflows the step 5 is ALCA. Could be related to the data types that are being read/written there.

Then I would be greedy and ask if we can add that to more DataFormats packages ?

Add what exactly?

Well I see this changes cover several DataFormats packages, including BTauReco, EgammaCandidates, EgammaReco, HcalIsolatedTrack, L1TCorrelator, L1TMuon, L1TParticleFlow, ParticleFlowReco, and RecoCandidate.

So can it cover more ? This my question

makortel · 2026-08-21T20:28:19Z

Just for my understanding, is this reduction expected? And why is it specifically in Step 5? It’s a little bit unclear to me.

Generally more compiled dictionaries for data types that ROOT serializes as opposed to header parsing can reduce memory. In several of the workflows the step 5 is ALCA. Could be related to the data types that are being read/written there.

Then I would be greedy and ask if we can add that to more DataFormats packages ?

Add what exactly?

Well I see this changes cover several DataFormats packages, including BTauReco, EgammaCandidates, EgammaReco, HcalIsolatedTrack, L1TCorrelator, L1TMuon, L1TParticleFlow, ParticleFlowReco, and RecoCandidate.

So can it cover more ? This my question

Theoretically that would be great, but practice is more complicated. These cases were found by running a job on a CMSSW build that was built on top of a ROOT debug build in gdb and inspecting stack traces for ExecAutoParse() function calls. @alexstrel is working to find more from a different job.

I'd love to have a better way to find missing dictionaries (see #49458), but we are not there yet.

Moanwar · 2026-08-21T20:56:20Z

+1

quinnanm · 2026-08-21T21:55:27Z

+l1

cmsbuild · 2026-08-21T21:55:50Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2026-08-22T05:51:28Z

+1

Added required dictionaries explicitly to fix unnecessary runtime aut…

40fca09

…oparsing.

cmsbuild added this to the CMSSW_20_1_X milestone Aug 19, 2026

cmsbuild added reconstruction-pending l1-pending pending-signatures tests-pending orp-pending code-checks-pending changes-dataformats labels Aug 19, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 19, 2026

makortel mentioned this pull request Aug 19, 2026

Heterogeneous Alpaka implementation of electron pixel seed-matching #51200

Open

makortel reviewed Aug 19, 2026

View reviewed changes

addressed PR comments

489d906

cmsbuild added code-checks-pending and removed code-checks-approved labels Aug 20, 2026

cmsbuild added code-checks-approved and removed code-checks-pending labels Aug 20, 2026

cmsbuild added tests-started and removed tests-pending labels Aug 21, 2026

cmsbuild added tests-approved and removed tests-started labels Aug 21, 2026

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Aug 21, 2026

cmsbuild added l1-approved fully-signed and removed l1-pending pending-signatures labels Aug 21, 2026

cmsbuild added orp-approved and removed orp-pending labels Aug 22, 2026

cmsbuild merged commit 29a27d6 into cms-sw:master Aug 22, 2026
10 checks passed

		@@ -1,5 +1,6 @@
		<lcgdict>

		<class name="std::vector<reco::io_v1::ElectronSeed::PMVars>"/>

		<class name="std::pair<reco::isodeposit::Direction::Distance,float>"/>
		<class name="std::map<reco::isodeposit::Direction::Distance,float>"/>

Uh oh!

Conversation

alexstrel commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Aug 19, 2026

Uh oh!

cmsbuild commented Aug 19, 2026

Uh oh!

makortel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Aug 20, 2026

Uh oh!

cmsbuild commented Aug 20, 2026

Uh oh!

makortel commented Aug 21, 2026

Uh oh!

cmsbuild commented Aug 21, 2026

Comparison Summary

Max Memory Comparisons exceeding threshold

Uh oh!

makortel commented Aug 21, 2026

Uh oh!

Moanwar commented Aug 21, 2026

Uh oh!

makortel commented Aug 21, 2026

Uh oh!

Moanwar commented Aug 21, 2026

Uh oh!

makortel commented Aug 21, 2026

Uh oh!

Moanwar commented Aug 21, 2026

Uh oh!

makortel commented Aug 21, 2026

Uh oh!

Moanwar commented Aug 21, 2026

Uh oh!

quinnanm commented Aug 21, 2026

Uh oh!

cmsbuild commented Aug 21, 2026

Uh oh!

mandrenguyen commented Aug 22, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

alexstrel commented Aug 19, 2026 •

edited

Loading

cmsbuild commented Aug 19, 2026 •

edited

Loading