Skip to content

Fix ActivityRegistry README.md - #51708

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
makortel:fixActivityRegistryDoc
Aug 17, 2026
Merged

Fix ActivityRegistry README.md#51708
cmsbuild merged 1 commit into
cms-sw:masterfrom
makortel:fixActivityRegistryDoc

Conversation

@makortel

Copy link
Copy Markdown
Contributor

PR description:

The {Pre,Post}ModuleEvent had ended up on the same line as {Pre,Post}ModuleEventDelayedGet and were not rendered. This PR fixes that.

Resolves cms-sw/framework-team#2391

PR validation:

The Markdown table renders now as expected.

@cmsbuild

cmsbuild commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51708/50606

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • FWCore/ServiceRegistry (core)

@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks.
@fwyzard, @wddgit this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones

Copy link
Copy Markdown
Contributor

looks good to me

@makortel

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

Even if there is nothing to test

@makortel

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please abort

@makortel

Copy link
Copy Markdown
Contributor Author

+core

Let's try out cms-sw/cms-bot#2824

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@mandrenguyen

Copy link
Copy Markdown
Contributor

Is cms-sw/cms-bot#2824 supposed to skip the tests even if you execute the test command (and still turn the tests-pending button green)?

@makortel

Copy link
Copy Markdown
Contributor Author

Note that I above I aborted the tests. Perhaps it would be good to turn the tests-pending label to e.g. tests-skipped when the bot makes the decision the tests can be skipped?

@makortel

Copy link
Copy Markdown
Contributor Author

I guess the present state of ORP's +1 not leading to merge is a bit annoying?

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

1 similar comment
@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@mandrenguyen

Copy link
Copy Markdown
Contributor

please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 16KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-31794d/55400/summary.html
COMMIT: 00f8248
CMSSW: CMSSW_20_1_X_2026-08-17-1100/el9_amd64_gcc14
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51708/55400/install.sh to create a dev area with all the needed externals and cmssw changes.

@cmsbuild
cmsbuild merged commit f1ac1db into cms-sw:master Aug 17, 2026
5 checks passed
@makortel

Copy link
Copy Markdown
Contributor Author

@smuzaffar Is the process with cms-sw/cms-bot#2824 still to issue the tests that are then no-op?

@smuzaffar

Copy link
Copy Markdown
Contributor

yes @makortel , one still needs to issue the test comment for no-op changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix ActivityRegistry README.md

5 participants