Fix ActivityRegistry README.md - #51708
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-51708/50606
|
|
A new Pull Request was created by @makortel for master. It involves the following packages:
@Dr15Jones, @cmsbuild, @makortel, @smuzaffar can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
looks good to me |
|
@cmsbuild, please test Even if there is nothing to test |
|
@cmsbuild, please abort |
|
+core Let's try out cms-sw/cms-bot#2824 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
Is cms-sw/cms-bot#2824 supposed to skip the tests even if you execute the test command (and still turn the tests-pending button green)? |
|
Note that I above I aborted the tests. Perhaps it would be good to turn the |
|
I guess the present state of ORP's |
|
+1 |
1 similar comment
|
+1 |
|
please test |
|
+1 Size: This PR adds an extra 16KB to repository |
|
@smuzaffar Is the process with cms-sw/cms-bot#2824 still to issue the tests that are then no-op? |
|
yes @makortel , one still needs to issue the test comment for no-op changes |
PR description:
The
{Pre,Post}ModuleEventhad ended up on the same line as{Pre,Post}ModuleEventDelayedGetand were not rendered. This PR fixes that.Resolves cms-sw/framework-team#2391
PR validation:
The Markdown table renders now as expected.