Skip to content

replace HLTP2GTTauFilter with an instace of HLTP2GTSingleObjectFilter - #51720

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
mmusich:mm_replaceHLTP2GTTauFilter
Aug 19, 2026
Merged

replace HLTP2GTTauFilter with an instace of HLTP2GTSingleObjectFilter#51720
cmsbuild merged 1 commit into
cms-sw:masterfrom
mmusich:mm_replaceHLTP2GTTauFilter

Conversation

@mmusich

@mmusich mmusich commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

PR description:

Title says it all, with the integration of #51669 we can retire HLTP2GTTauFilter as it is superseded by the more general HLTP2GTSingleObjectFilter.

PR validation:

  • cmssw compiles.
  • runTheMatrix.py -l ph2_hlt -i all --ibeos runs fine.
  • Bitwise trigger results compatibility to be tested by the bot.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild

cmsbuild commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

@mmusich

mmusich commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

test parameters:

  • enable = hlt_p2_integration, hlt_p2_timing
  • workflows = ph2_hlt

@mmusich

mmusich commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c3f3e/55405/summary.html
COMMIT: f25b027
CMSSW: CMSSW_20_1_X_2026-08-17-1100/el9_amd64_gcc14
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51720/55405/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c3f3e/55405/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c3f3e/55405/git-merge-result

HLT P2 Timing: chart
DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 59
  • DQMHistoTests: Total histograms compared: 4088350
  • DQMHistoTests: Total failures: 46
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4088286
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 442.6400000000001 KiB( 58 files compared)
  • DQMHistoSizes: changed ( 37634.0,... ): 2.233 KiB HLTGenVal/ele__HLT_Photon108EB_TightID_TightIso_L1Seeded__hltEGL1SeedsForSinglePhotonIsolatedFilter__2Dvsetaphi
  • DQMHistoSizes: changed ( 37634.0,... ): 2.219 KiB HLTGenVal/ele__HLT_Ele115_NonIso_L1Seeded__hltEGL1SeedsForSingleEleNonIsolatedFilter__2Dvsetaphi
  • DQMHistoSizes: changed ( 37634.0,... ): 2.216 KiB HLTGenVal/ele__HLT_Ele32_WPTight_L1Seeded__hltEGL1SeedsForSingleEleIsolatedFilter__2Dvsetaphi
  • DQMHistoSizes: changed ( 37634.0,... ): 2.213 KiB HLTGenVal/ele__HLT_Ele26_WP70_L1Seeded__hltEGL1SeedsForSingleEleIsolatedFilter__2Dvsetaphi
  • DQMHistoSizes: changed ( 37634.0,... ): 1.778 KiB HLTGenVal/MET__HLT_PFPuppiMETTypeOne140_PFPuppiMHT140__hltL1SeedsForPuppiMETFilter__2Dvspteta
  • DQMHistoSizes: changed ( 37634.0,... ): 1.768 KiB HLTGenVal/mu__HLT_IsoMu24_FromL1TkMuon__hltSingleTkMuon22L1TkMuonFilter__2Dvspteta
  • DQMHistoSizes: changed ( 37634.0,... ): 1.765 KiB HLTGenVal/mu__HLT_Mu50_FromL1TkMuon__hltSingleTkMuon22L1TkMuonFilter__2Dvspteta
  • DQMHistoSizes: changed ( 37634.0,... ): 1.764 KiB HLTGenVal/AK4jet__HLT_AK4PFPuppiJet520__hltL1SeedsForPuppiJetFilter__2Dvspteta
  • DQMHistoSizes: changed ( 37634.0,... ): 1.759 KiB HLTGenVal/AK4HT__HLT_PFPuppiHT1070__hltL1SeedsForPuppiHTFilter__2Dvspteta
  • DQMHistoSizes: changed ( 37634.0,... ): 0.271 KiB HLTGenVal/ele__HLT_Photon108EB_TightID_TightIso_L1Seeded__hltEGL1SeedsForSinglePhotonIsolatedFilter__vspt__barrel
  • DQMHistoSizes: changed ( 37634.0 ): ...
  • Checked 249 log files, 203 edm output root files, 59 DQM output files
  • TriggerResults: no differences found

@mmusich

mmusich commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

  • to get rid of the spurious merge commits

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 40KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5c3f3e/55418/summary.html
COMMIT: f25b027
CMSSW: CMSSW_20_1_X_2026-08-17-2300/el9_amd64_gcc14
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51720/55418/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart
DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 59
  • DQMHistoTests: Total histograms compared: 4089582
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4089546
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 58 files compared)
  • Checked 249 log files, 203 edm output root files, 59 DQM output files
  • TriggerResults: no differences found

@mmusich
mmusich marked this pull request as ready for review August 18, 2026 12:26
@mmusich

mmusich commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

also tested with:

#! /bin/bash

#LOCALPATH='/cms-hlt-nfs/data/relValMinBiasL1Skim_200PU/CMSSW_20_0_0_pre1'
LOCALPATH='/cms-hlt-nfs/data/relValTTbar_200PU/CMSSW_20_0_0_pre1/'
echo "Input source: |${LOCALPATH}|"
LOCALFILES=$(ls -1 ${LOCALPATH} | grep root)
ALL_FILES=""
for f in ${LOCALFILES[@]}; do
    ALL_FILES+="file:${LOCALPATH}/${f},"
done
# Remove the last character                                                                                                                                               
ALL_FILES="${ALL_FILES%?}"
echo "Discovered files: $ALL_FILES"

### Timing menu, current status
cmsDriver.py Phase2 -s L1P2GT,HLT:75e33_timing \
             --processName=HLTX \
             --conditions auto:phase2_realistic_T35 \
             --geometry ExtendedRun4D121 \
             --era Phase2C22I13M9 \
             --customise SLHCUpgradeSimulations/Configuration/aging.customise_aging_1000 \
             --eventcontent FEVTDEBUGHLT \
             --outputCommands "drop *, keep edmTriggerResults_*_*_HLTX,keep *_hltTriggerSummaryAOD_*_HLTX" \
             --filein=$ALL_FILES \
             --mc \
             --inputCommands="keep *, drop *_hlt*_*_HLT, drop triggerTriggerFilterObjectWithRefs_l1t*_*_HLT" \
             --nConcurrentLumis 8 \
             -n 5000 \
             --nThreads 48 \
             --customise_commands "process.options.wantSummary=True" \
             --no_exec \
             --accelerators cpu \
             --fileout=OutHLT_mod_cpu2.root \
             --python_filename hlt.py

edmConfigDump hlt.py > HLTTimingComplete_config.py

cmsRun HLTTimingComplete_config.py >& HLTTimingComplete.log

and compared the trigger results of 5k TTbar events + PU = 200, obtaining:

$ hltDiff -o OutHLT_mod_cpu2.root -n ../../Vanilla/CMSSW_20_1_0_pre2/src/OutHLT_cpu.root   
Processed events: 0 out of 5000 (0%)
Processed events: 500 out of 5000 (10%)
Processed events: 1000 out of 5000 (20%)
Processed events: 1500 out of 5000 (30%)
Processed events: 2000 out of 5000 (40%)
Processed events: 2500 out of 5000 (50%)
Processed events: 3000 out of 5000 (60%)
Processed events: 3500 out of 5000 (70%)
Processed events: 4000 out of 5000 (80%)
Processed events: 4500 out of 5000 (90%)
Found 5000 matching events, out of which 0 have different HLT results

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • HLTrigger/HLTfilters (hlt)

@Martin-Grunewald, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich

mmusich commented Aug 18, 2026

Copy link
Copy Markdown
Contributor Author

+hlt

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit 15a5d43 into cms-sw:master Aug 19, 2026
13 checks passed
@mmusich
mmusich deleted the mm_replaceHLTP2GTTauFilter branch August 19, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants