Skip to content

Allow bot to ignore changed files e.g. when github api has not properly updated file count - #2806

Merged
smuzaffar merged 1 commit into
masterfrom
large-prs-files
Jul 2, 2026
Merged

Allow bot to ignore changed files e.g. when github api has not properly updated file count#2806
smuzaffar merged 1 commit into
masterfrom
large-prs-files

Conversation

@smuzaffar

Copy link
Copy Markdown
Contributor

@cmsbuild

cmsbuild commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @smuzaffar for branch master.

@akritkbehera, @cmsbuild, @iarspider, @raoatifshad, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild

cmsbuild commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

Comment thread process_pr.py Outdated
pr = repo.get_pull(prId)
if pr.changed_files == 0:
if (pr.changed_files == 0) and (
not [

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any(line == "<cmsbot ignore-changed-files/>" for line in ensure_ascii(pr.body).split("\n"))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smuzaffar should I forward-port this to the new bot?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @iarspider

@cmsbuild

cmsbuild commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Pull request #2806 was updated.

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please test with cms-sw/root#233 for CMSSW_20_1_ROOT6_X

@smuzaffar

Copy link
Copy Markdown
Contributor Author

abort

@smuzaffar

Copy link
Copy Markdown
Contributor Author

please test

@smuzaffar

Copy link
Copy Markdown
Contributor Author

+externals

bot processign showed no issues, so let merge it so that bot can properly process cms-sw/root#233

@smuzaffar
smuzaffar merged commit b65cbf9 into master Jul 2, 2026
11 of 13 checks passed
@cmsbuild

cmsbuild commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild

cmsbuild commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae6731/54469/summary.html
COMMIT: ce2dbae
CMSSW: CMSSW_20_1_X_2026-07-01-2300/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2806/54469/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 45
  • DQMHistoTests: Total histograms compared: 3414477
  • DQMHistoTests: Total failures: 70
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3414389
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 44 files compared)
  • Checked 195 log files, 163 edm output root files, 45 DQM output files
  • TriggerResults: no differences found

@smuzaffar
smuzaffar deleted the large-prs-files branch July 3, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants